[LexicalDestroyHoisting] Adopt iterative dataflow. #58939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nate-chandler
changed the title
nate-chandler
force-pushed
the
rdar93369506
branch
from
a298594 to
d20a6c3
Compare
|
@swift-ci please test |
atrick
reviewed
May 19, 2022
|
Same comment for LexicalDestroyHoisting... The boilerplate detracts from readability. But I think that's mostly solved by moving the small method bodies in-line with the class definition--the ones that just provide abstraction or implement template interfaces, but don't have any nontrivial switches or loops. |
nate-chandler
force-pushed
the
rdar93369506
branch
from
d20a6c3 to
1e0ac12
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
rdar93369506
branch
from
1e0ac12 to
50ac9ee
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Adopt IterativeBackwardReachability. Enables hoisting destroy_values over loops. rdar://93369506
Avoids hoisting destroy_values into unrelated access scopes which could introduce exclusivity violations.
nate-chandler
force-pushed
the
rdar93369506
branch
from
50ac9ee to
e68c12f
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
atrick
reviewed
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt IterativeBackwardReachability and VisitBarrierAccessScopes. Enables hoisting destroy_values over loops and avoiding hoisting destroy_values into unrelated access scopes, respectively.
rdar://93369506