add default values for SymbolGraphOptions #59037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please build toolchain macOS |
QuietMisdreavus
force-pushed
the
QuietMisdreavus/clang-syms-while-building
branch
from
f682cc6 to
b42b0ed
Compare
|
@swift-ci Please test |
QuietMisdreavus
changed the title
franklinsch
approved these changes
May 25, 2022
bnbarham
reviewed
May 25, 2022
Comment on lines
24
to
27
| StringRef OutputDir = StringRef{}; | ||
|
|
||
| /// The target of the module. | ||
| llvm::Triple Target; | ||
| llvm::Triple Target = llvm::Triple{}; |
There was a problem hiding this comment.
These are default initialized already, but providing it doesn't hurt. You could just do = {}; if you want to keep though.
There was a problem hiding this comment.
I'm being extra paranoid now, since i was assuming that bool had a default initialization as well. 😅 I can clean up the initializer value, though. Thanks for the tip!
bnbarham
approved these changes
May 25, 2022
|
@swift-ci Please test |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://93780666
Currently, the
IncludeClangDocsfield ofSymbolGraphOptionsis uninitialized when generating a symbol graph during a build. The assumption behind this field is that the branches that it gates would only be run when generating a symbol graph from SourceKit. However, we've noticed a situation where the symbol graph is emitting the partial "location" field during a build on ARM macOS. This PR adds defaults to theSymbolGraphOptionsstruct, as well as manually setting theIncludeClangDocsfield tofalsewhen building, to ensure that this code path is never hit during a regular compile.