[TypeChecker] SE-0324: Extend Swift -> C pointer conversions to inout
#59051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
approved these changes
May 25, 2022
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility debug |
atrick
approved these changes
May 25, 2022
There was a problem hiding this comment.
Thank you Pavel!
I guess for completeness the tests could also add:
void const_opt_void_ptr_func(const void * _Nullable buffer);
And could call
const_int_${Size}_ptr_func(&x${Size}) // OK
const_uint_${Size}_ptr_func(&x${Size}) // OK
const_opt_int_${Size}_ptr_func(&x${Size}) // OK
const_opt_uint_${Size}_ptr_func(&x${Size}) // OK
Fixes an oversight where `inout` -> C pointer conversion wasn't covered by implementation of new pointer conversion semantics proposed by SE-0324. Resolves: rdar://92583588
|
Done! |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight where
inout-> C pointer conversion wasn't coveredby implementation of new pointer conversion semantics proposed by SE-0324.
Resolves: rdar://92583588