[CSGen] Emulate separate type-checking of $generator variable of for-in loop
#59560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-in loop Emulate previous `for-in` type-checking behavior where sequence was type-checked separately from `.next()` call which, in turn, was injected only during SIL generation. Current approach to generate an implicit variable for `$generator` and use it as a base to `.next()` call didn't account for the fact that it allows the solver to rank result of `<sequence>.makeIterator()` together with result of `next()`. This is logically incorrect because `<sequence>.makeIterator()` represents initializer of `$generator` which is separate from `$generator.next()` expression albeit type-checked together. Resolves: swiftlang#59522
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emulate previous
for-intype-checking behavior where sequencewas type-checked separately from
.next()call which, in turn,was injected only during SIL generation.
Current approach to generate an implicit variable for
$generatorand use it as a base to
.next()call didn't account for the factthat it allows the solver to rank result of
<sequence>.makeIterator()together with result of
next(). This is logically incorrect because<sequence>.makeIterator()represents initializer of$generatorwhich is separate from
$generator.next()expression albeit type-checkedtogether.
Resolves: #59522