Skip to content

[DependencyScanning] Count target variant, clang target, and sdk versions as components of scanning context hash #62471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Dec 8, 2022

Otherwise we get unintended collisions in cases like: scanning for the same target but a different target variant, e.g. Catalyst.

@artemcm
Copy link
Contributor Author

artemcm commented Dec 8, 2022

@swift-ci smoke test

@artemcm artemcm force-pushed the FixForDepScanGlobalCacheContext branch 2 times, most recently from 98c8b42 to 11ab991 Compare December 8, 2022 23:07
@artemcm
Copy link
Contributor Author

artemcm commented Dec 8, 2022

@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Dec 9, 2022

@swift-ci smoke test macOS platform

@artemcm artemcm force-pushed the FixForDepScanGlobalCacheContext branch from 11ab991 to b357403 Compare December 9, 2022 17:17
@artemcm
Copy link
Contributor Author

artemcm commented Dec 9, 2022

@swift-ci smoke test

…ions as components of scanning context hash

Resolves rdar://103093122
@artemcm artemcm force-pushed the FixForDepScanGlobalCacheContext branch from b357403 to 44a8f99 Compare December 9, 2022 17:24
@artemcm
Copy link
Contributor Author

artemcm commented Dec 9, 2022

@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Dec 9, 2022

@swift-ci smoke test macOS platform

@artemcm artemcm merged commit a7726f1 into swiftlang:main Dec 12, 2022
@artemcm artemcm deleted the FixForDepScanGlobalCacheContext branch December 12, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant