[Sema] RuntimeMetadata: Add support for mutating/async methods and functions via a thunk #62738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please build toolchain macOS |
xedin
force-pushed
the
runtime_attr_method_thunks
branch
from
8470938 to
efa9b13
Compare
xedin
changed the title
Instead of passing an unapplied reference to a (either static or instance) method, let's form a thunk and use it to forward arguments to the underlying method invocation. This way it's possible to get a uniform type for all instance methods that always starts with `self` type and supports `mutating` methods by marking `self` as `inout`.
…hods Add support for global async functions and actor-isolated methods by determining isolation context of the method attribute is associated with and injecting try/await when appropriate.
xedin
force-pushed
the
runtime_attr_method_thunks
branch
from
efa9b13 to
23cf6a1
Compare
|
@swift-ci please build toolchain macOS |
|
@swift-ci please smoke test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing an unapplied reference to a (either static or instance) method,
let's form a thunk and use it to forward arguments to the underlying method invocation.
This way it's possible to get a uniform type for all instance methods that always starts
with
selftype and supportsmutatingand actor-isolated methods as well asasyncfunctions.