Skip to content

Sema/IRGen: Add clang decl support to #_hasSymbol #62745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

tshortli
Copy link
Contributor

Update if #_hasSymbol diagnostics and codegen to support clang functions and Obj-C class declarations. Support for global variables requires more infrastructural changes and will be handled in a follow up. Support for direct Obj-C methods/properties will also be implemented in the future.

Resolves rdar://103408651

@tshortli
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Can these clang decls also be handled via respondsToSelector?

@tshortli tshortli force-pushed the has-symbol-clang-decls branch from c51e2d1 to 2e8857d Compare December 22, 2022 15:55
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli
Copy link
Contributor Author

Cool! Can these clang decls also be handled via respondsToSelector?

Selectors represent Obj-C methods so they can't be used to represent C functions or globals.

@nkcsgexi
Copy link
Contributor

Cool! Can these clang decls also be handled via respondsToSelector?

Selectors represent Obj-C methods so they can't be used to represent C functions or globals.

Makes sense.

@tshortli
Copy link
Contributor Author

tshortli commented Jan 3, 2023

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 7214650 into swiftlang:main Jan 3, 2023
@tshortli tshortli deleted the has-symbol-clang-decls branch January 3, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants