Skip to content

[cxx-interop] Treat name lookup as successful if we found a C++ member operator #62763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

egorzhdan
Copy link
Contributor

ClangImporter::Implementation::lookupValue used to return false if it found an overloaded C++ operator that is declared as a member function of a C++ type.

This doesn't have any effect now since the return value isn't used under normal conditions, but it might bite us later.

…r operator

`ClangImporter::Implementation::lookupValue` used to return `false` if it found an overloaded C++ operator that is declared as a member function of a C++ type.

This doesn't have any effect now since the return value isn't used under normal conditions, but it might bite us later.
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Dec 22, 2022
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

1 similar comment
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan merged commit 0620226 into main Jan 3, 2023
@egorzhdan egorzhdan deleted the egorzhdan/cxx-op-lookup-false branch January 3, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant