Skip to content

[Backtracing] Add support for building target executables into libexec. #63650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

al45tair
Copy link
Contributor

We're going to add a program, swift-backtrace, that gets built alongside the stdlib and the runtime, and that needs to be installed in libexec/swift alongside the libraries in lib/swift.

It wants to be built with the stdlib/runtime because there's an internal interface between swift-backtrace and the runtime, so the program needs to stay in lock-step with the runtime library.

rdar://105390807

We're going to add a program, `swift-backtrace`, that gets built alongside
the stdlib and the runtime, and that needs to be installed in libexec/swift
alongside the libraries in lib/swift.

It wants to be built with the stdlib/runtime because there's an internal
interface between `swift-backtrace` and the runtime, so the program needs
to stay in lock-step with the runtime library.

rdar://105390807
@al45tair al45tair changed the title Add support for building target executables into libexec. [Backtracing] Add support for building target executables into libexec. Feb 14, 2023
@al45tair
Copy link
Contributor Author

al45tair commented Feb 14, 2023

This is part of a set of stacked PRs:

PR Title Merges Into
👉 #63650 [Backtracing] Add support for building target executables into libexec main
al45tair#8 [Backtracing] Add support for looking up paths for auxiliary executables #63650
al45tair#9 [Backtracing][Runtime][Darwin] Add code to trigger the external backtracer al45tair#8
al45tair#10 [Backtracing] Add _Backtracing library to the build al45tair#9
al45tair#11 [Backtracing][Frontend] Add support for implicit import of _Backtracing al45tair#10
al45tair#12 [Backtracing] Add swift-backtrace to the build al45tair#11
al45tair#13 [Backtracing][Docs] Add an explanation of the workings of the backtracer al45tair#12
al45tair#14 [Backtracing] Add control over symbol caching al45tair#13

(Only the bottom PR will be able to run PR checks at any time. Please don't wait for the checks before review.)

@al45tair
Copy link
Contributor Author

@swift-ci Please smoke test linux platform

@al45tair al45tair marked this pull request as ready for review February 14, 2023 15:27
@al45tair al45tair requested review from edymtt and etcwilde February 14, 2023 15:27
@etcwilde
Copy link
Contributor

Looking, still making sense of what all of the list(APPEND...)s connect to.

@etcwilde
Copy link
Contributor

I think the high-level of where things are going seems sensible to me. I'm not familiar enough with Windows to say on that front. I'm still trying to figure out what an end "happy" state for CMake will look like once I can start using new cmake 3.26 features. I'll keep looking at this tomorrow though.

Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catalyst stuff makes me sad, but I can't think of any tricks to make them nicer at the moment.

CC @compnerd for comments and thoughts on the Windows side of things.

@al45tair al45tair merged commit b88f3b6 into swiftlang:main Feb 28, 2023
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Feb 28, 2023
…add-libexec"

This reverts commit b88f3b6, reversing
changes made to be4caa5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants