Skip to content

add test to ensure consistent compatibility macro definitions #64086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://106087804

This PR adds a test to ensure that all the compatibility macro definitions are the same as they were in Swift 5.7, ensuring that all the "macro redefinition" errors introduced by #59072 are now resolved. This test copies in a header generated by Swift 5.7, slightly modified to force the macros to be redefined. In this situation, any difference in compatibility macros that existed in Swift 5.7, however slight, will introduce an error.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

1 similar comment
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please clean test macOS

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please clean test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

1 similar comment
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test Linux

@QuietMisdreavus QuietMisdreavus merged commit c63d899 into main Apr 26, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/compat-test branch April 26, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant