[cxx-interop] Allow disabling Cxx build when building stdlib #65264
Conversation
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cmake-option-build-cxx
branch
from
43cdf6a to
6e0b8f3
Compare
|
@swift-ci please smoke test |
| @@ -74,7 +74,6 @@ set(LLDB_ENABLE_LIBXML2 NO CACHE BOOL "") | |||
| set(SWIFT_INCLUDE_DOCS NO CACHE BOOL "") | |||
| set(SWIFT_BUILD_ENABLE_PARSER_LIB YES CACHE BOOL "") | |||
| set(SWIFT_BUILD_STDLIB_EXTRA_TOOLCHAIN_CONTENT NO CACHE BOOL "") | |||
| set(SWIFT_BUILD_STDLIB_CXX_MODULE NO CACHE BOOL "") | |||
There was a problem hiding this comment.
Why is this being removed? We don't build any of the runtime components in the toolchain.
There was a problem hiding this comment.
I stumbled upon a mass test failure on Windows with this patch, apparently the swiftCxx binary was not built.
Let me try enabling it in the runtime configurations.
There was a problem hiding this comment.
Looks like the swiftCxx module is still not built when I specify SWIFT_BUILD_STDLIB_CXX_MODULE=YES in the runtime presets.
LINK : fatal error LNK1104: cannot open file 'swiftCxx.lib'
There was a problem hiding this comment.
I'm not super familiar with the build pipeline on Windows. Since the Cxx module is shipped with the toolchain, would it be acceptable to build it alongside the toolchain as well?
There was a problem hiding this comment.
No, that wouldn't. That would basically force the stdlib to always be required, and we cannot do that because it takes too long.
| @@ -73,7 +73,6 @@ set(LLDB_EMBED_PYTHON_HOME NO CACHE BOOL "") | |||
| set(SWIFT_INCLUDE_DOCS NO CACHE BOOL "") | |||
| set(SWIFT_BUILD_ENABLE_PARSER_LIB YES CACHE BOOL "") | |||
| set(SWIFT_BUILD_STDLIB_EXTRA_TOOLCHAIN_CONTENT NO CACHE BOOL "") | |||
| set(SWIFT_BUILD_STDLIB_CXX_MODULE NO CACHE BOOL "") | |||
This makes it possible to pass `SWIFT_BUILD_STDLIB_CXX_MODULE=FALSE` to CMake to disable Cxx and CxxStdlib modules when building the Swift stdlib or the SDK overlay. rdar://108206321
egorzhdan
force-pushed
the
egorzhdan/cmake-option-build-cxx
branch
from
6e0b8f3 to
14e6901
Compare
|
@swift-ci please smoke test |
This makes it possible to pass `SWIFT_BUILD_STDLIB_CXX_MODULE=FALSE` to CMake to disable Cxx and CxxStdlib modules when building the Swift stdlib or the SDK overlay. rdar://108206321
|
@swift-ci please smoke test |
|
Duplicate of #65398 |
This makes it possible to pass
SWIFT_BUILD_STDLIB_CXX_MODULE=FALSEto CMake to disable Cxx and CxxStdlib modules when building the Swift stdlib or the SDK overlay.rdar://108206321