fix Builtin.sizeof et al for metatypes
#65354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
How does this affect code like: unsafeBitCast(Int.self, to: UnsafeRawPointer.self)? Previously this would assert at runtime because of the size mismatch, but with this change would this actually succeed now? |
yes |
slavapestov
reviewed
Apr 21, 2023
| @@ -120,6 +120,12 @@ getLoweredTypeAndTypeInfo(IRGenModule &IGM, Type unloweredType) { | |||
| return {lowered, IGM.getTypeInfo(lowered)}; | |||
| } | |||
|
|
|||
| static std::pair<SILType, const TypeInfo &> | |||
| getMaximallyAbstractedLoweredTypeAndTypeInfo(IRGenModule &IGM, Type unloweredType) { | |||
There was a problem hiding this comment.
Is this function unused?
There was a problem hiding this comment.
Good catch!
And also the test was wrong: I need to disable the target-constant-folding pass. Otherwise the builtins are already constant folded before they reach IRGen.
Fixed.
Those builtins always need to assume a thick metatype which is a pointer. In other words the builtins need to use the maximally abstracted type. rdar://108308786
eeckstein
force-pushed
the
fix-sizeof-builtin
branch
from
7582779 to
f5a0519
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those builtins always need to assume a thick metatype which is a pointer. In other words the builtins need to use the maximally abstracted type.
rdar://108308786