-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[CAS] Add caching diagnostic processor #65423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAS] Add caching diagnostic processor #65423
Conversation
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also tested via default all the diagnostics to capture and replayed via CachedDiagnosticsProcessor and pass all the tests.
To clarify, is this something that is always happening, or something you did manually?
Manually, we can also leave a switch in there for testing purpose. There isn't a good way to dup all tests with a different configuration to have this always on and probably very expensive. |
Okay, I would like to see more explicit test coverage then for different kinds of diagnostics (notes, errors, educational notes, if there are any "stack" output similar to clang's include stacks), different output format (.diag file, stderr, different formatting options for the stderr output). |
762b106
to
608c58f
Compare
@swift-ci please smoke test |
608c58f
to
7ca2548
Compare
@swift-ci please smoke test |
Add a CachedDiagnosticsProcessor that is a DiagConsumer can capture all the diagnostics during a compilation, serialized them into CAS with a format that can be replayed without re-compiling.
7ca2548
to
d3891a8
Compare
@swift-ci please smoke test |
ping |
Add a CachedDiagnosticsProcessor that is a DiagConsumer can capture all the diagnostics during a compilation, serialized them into CAS with a format that can be replayed without re-compiling.
This is also tested via default all the diagnostics to capture and replayed via CachedDiagnosticsProcessor and pass all the tests.