[5.8] Relax FileCheck directives for skip_clean_llbuild.test
#66064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed short term to allow the test to pass when running on Python 3.11 and later and avoid errors like ``` <stdin>:44:1: note: non-matching line after previous match is here <string>:1: DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13 ^ ``` Long term we want to replace uses of the obsolete `pipes.quotes` function with `shlex.quotes`. Addresses rdar://109664710 (cherry picked from commit 1534925, swiftlang#66062)
|
@swift-ci please test |
|
@swift-ci please test Apple Silicon |
|
@swift-ci please build toolchain |
|
The Apple Silicon runs fails with a Python lint error Looks like I may need to cherry-pick #63237 to make that pass |
- lowercase-l trips some python lint configurations (cherry picked from commit 36d230e, swiftlang#63237)
|
@swift-ci please test |
|
@swift-ci please test Apple Silicon |
|
@swift-ci please build toolchain |
|
|
|
@swift-ci please test Apple Silicon |
shahmishal
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed short term to allow the test to pass when running on Python 3.11 and later and avoid errors like
Long term we want to replace uses of the obsolete
pipes.quotesfunction withshlex.quotes.Piggyback a change in
round-trip-syntax-testfrom #63237 to avoid Python linting errors.Addresses rdar://109664710
(cherry picked from commit 1534925,
#66062)