Skip to content

[SIL] InitAccessors: Support assign_or_init in textual SIL #67593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 31, 2023
Merged

[SIL] InitAccessors: Support assign_or_init in textual SIL #67593

merged 8 commits into from
Jul 31, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 28, 2023

  • Implement printing for @storageRestrictions attribute
  • Augment parser to accept init accessors in SIL context
  • Add referenced init accessor property to assign_or_init and route initializes/accesses requests through it

@xedin xedin requested review from jckarter and atrick July 28, 2023 17:46
atrick
atrick approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!
Could you add a test for the case where an init accessor is in a protocol requirement. I didn't quite understand how that is possible.
...and thanks for the cleaning this up:
7777ed5

@xedin
Copy link
Contributor Author

xedin commented Jul 28, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jul 29, 2023

@swift-ci please test macOS platform

@ahoppen ahoppen removed their request for review July 29, 2023 17:05
@xedin xedin merged commit a22bd27 into swiftlang:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick approved these changes

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @atrick