[CodeComplete] Avoid let/var completions in a few cases
#67704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't suggest `let` or `var` in e.g the sequence expression of a `for` loop, or after a `return`. We ought to do a better job of checking whether we're in expression position before suggesting these (as opposed to a pattern), but I'm leaving that as future work for now.
hamishknight
requested review from
ahoppen,
bnbarham and
rintaro
as code owners
|
@swift-ci please test |
ahoppen
approved these changes
Aug 3, 2023
|
Hopefully we can just remove all the keyword completions in sourcekitd once we have swiftlang/swift-syntax#1014. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't suggest
letorvarin e.g the sequence expression of aforloop, or after areturn. We ought to do a better job of checking whether we're in expression position before suggesting these (as opposed to a pattern), but I'm leaving that as future work for now.