Skip to content

[CS] Solve all conjunctions in source order #67800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2023
Merged

[CS] Solve all conjunctions in source order #67800

merged 2 commits into from
Aug 11, 2023

Conversation

hamishknight
Copy link
Contributor

Previously we would only do source ordering for ClosureExprs, but other conjunctions need to have their source location taken into account too, in order to make sure we don't try and type-check e.g a TapExpr in a second closure before we type-check the first closure.

Also while here, switch to std::min_element instead of sorting, and treat invalid source locations as incomparable.

rdar://113326835

@hamishknight
[AST] Improve source range info for TapExpr
1e3dd5c 
Previously we would only base the start loc on the
`SubExpr`, but that isn't set until CSApply. Change
it to take both `SubExpr` and `Body`'s source range
into account.

Also tighten up the invariant that a TapExpr must
be created with a non-null BraceStmt.
@hamishknight
[CS] Solve all conjunctions in source order
bc31eb1 
Previously we would only do source ordering for
ClosureExprs, but other conjunctions need to have
their source location taken into account too, in
order to make sure we don't try and type-check e.g
a TapExpr in a second closure before we type-check
the first closure.

Also while here, switch to `std::min_element`
instead of sorting, and treat invalid source
locations as incomparable.

rdar://113326835
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight
Copy link
Contributor Author

@swift-ci please test source compatibility

@hamishknight
Copy link
Contributor Author

@swift-ci please smoke test compiler performance

@hamishknight
Copy link
Contributor Author

@swift-ci please test compiler performance

@xedin
Copy link
Contributor

xedin commented Aug 8, 2023

Thanks! I'll take a look later today or tomorrow!

xedin
xedin approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It seems like a good time to generalize favoredOverConjunction to account for the expanded scope conjunctions now have…

@hamishknight
Copy link
Contributor Author

@swift-ci please smoke test compiler performance

@hamishknight
Copy link
Contributor Author

@swift-ci please test compiler performance

@hamishknight
Copy link
Contributor Author

Summary for main full

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 129,558,492,721,662 129,502,102,422,498 -56,390,299,164 -0.04%
LLVM.NumLLVMBytesOutput 2,536,493,992 2,536,511,888 17,896 0.0%

debug-batch detailed

Regressed (1)
name old new delta delta_pct
AST.ModuleShadowCacheHit 68,374 69,173 799 1.17% ⛔
Improved (1)
name old new delta delta_pct
AST.NumSourceLinesPerSecond 4,791,482 4,626,049 -165,433 -3.45% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (330)
name old new delta delta_pct
AST.ImportSetCacheHit 4,020,457 4,020,298 -159 -0.0%
AST.ImportSetCacheMiss 791,653 791,650 -3 -0.0%
AST.ImportSetFoldHit 400,719 400,713 -5 -0.0%
AST.ImportSetFoldMiss 390,934 390,936 2 0.0%
AST.ModuleShadowCacheMiss 5,139 5,172 33 0.64%
AST.ModuleVisibilityCacheHit 28,935,171 28,935,171 0 -0.0%
AST.ModuleVisibilityCacheMiss 213,067 213,067 0 -0.0%
AST.NumASTBytesAllocated 61,501,686,064 61,476,349,477 -25,336,586 -0.04%
AST.NumASTScopeExpansions 8,944,437 8,944,407 -29 -0.0%
AST.NumASTScopeLookups 9,962,824 9,962,612 -212 -0.0%
AST.NumDecls 350,205 350,205 0 0.0%
AST.NumDependencies 393,858 393,857 0 -0.0%
AST.NumIncrementalDependencies 25,872 25,872 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 320,086 320,086 0 0.0%
AST.NumLocalTypeDecls 6,622 6,622 0 0.0%
AST.NumModuleLookupClassMember 6,798 6,798 0 0.0%
AST.NumModuleLookupValue 117,223,106 117,220,691 -2,415 -0.0%
AST.NumObjCMethods 95,391 95,391 0 0.0%
AST.NumOperators 1,028 1,028 0 0.0%
AST.NumPrecedenceGroups 176 176 0 0.0%
AST.NumReferencedDynamicNames 159 159 0 0.0%
AST.NumReferencedMemberNames 15,426,627 15,426,627 0 0.0%
AST.NumReferencedTopLevelNames 1,372,295 1,372,295 0 0.0%
AST.NumSourceBuffers 397,628 397,628 0 0.0%
AST.NumSourceLines 12,901,704 12,901,704 0 0.0%
AST.NumTotalClangImportedEntities 1,819,443 1,818,312 -1,131 -0.06%
Frontend.MaxMallocUsage 0 0 0 0.0%
Frontend.NumInstructionsExecuted 129,558,492,721,662 129,502,102,422,498 -56,390,299,164 -0.04%
Frontend.NumProcessFailures 31 31 0 0.0%
IRGen.IRGenRequest 29,451 29,451 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 310,025 310,025 0 0.0%
IRModule.NumIRAliases 251,232 251,232 0 0.0%
IRModule.NumIRBasicBlocks 8,631,600 8,631,600 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 4,658,370 4,658,370 0 0.0%
IRModule.NumIRGlobals 4,397,281 4,397,281 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 90,090,376 90,090,376 0 0.0%
IRModule.NumIRNamedMetaData 119,326 119,326 0 0.0%
IRModule.NumIRValueSymbols 9,135,143 9,135,143 0 0.0%
LLVM.NumLLVMBytesOutput 2,536,493,992 2,536,511,888 17,896 0.0%
Parse.ExportedSourceFileRequest 4 4 0 0.0%
Parse.IDEInspectionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 420,124 420,124 0 0.0%
Parse.NumIterableDeclContextParsed 837,927 837,911 -16 -0.0%
Parse.ParseAbstractFunctionBodyRequest 709,463 709,463 0 0.0%
Parse.ParseMembersRequest 642,705 642,689 -16 -0.0%
Parse.ParseSourceFileRequest 372,326 372,326 0 0.0%
Parse.ParseTopLevelDeclsRequest 372,326 372,326 0 0.0%
SILGen.ASTLoweringRequest 30,635 30,635 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 3,675,500 3,675,500 0 0.0%
SILModule.NumSILGenGlobalVariables 143,341 143,341 0 0.0%
SILModule.NumSILGenVtables 40,663 40,663 0 0.0%
SILModule.NumSILGenWitnessTables 213,927 213,927 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 4,188,934 4,188,934 0 0.0%
SILModule.NumSILOptGlobalVariables 145,406 145,406 0 0.0%
SILModule.NumSILOptVtables 41,032 41,032 0 0.0%
SILModule.NumSILOptWitnessTables 258,630 258,630 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 150,837 150,837 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 319,740 319,739 -1 -0.0%
Sema.AbstractGenericSignatureRequest 151,272 151,186 -85 -0.06%
Sema.AccessLevelRequest 19,513,771 19,475,806 -37,965 -0.19%
Sema.ActorIsolationRequest 7,273,695 7,273,699 4 0.0%
Sema.AllMembersRequest 179,370 179,370 0 0.0%
Sema.AnyObjectLookupRequest 234 234 0 0.0%
Sema.ApplyAccessNoteRequest 4,568,963 4,568,684 -279 -0.01%
Sema.AreAllStoredPropertiesDefaultInitableRequest 50,596 50,596 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 33,130 33,130 0 0.0%
Sema.AttachedPropertyWrappersRequest 23,561,595 23,536,158 -25,436 -0.11%
Sema.AttachedResultBuilderRequest 1,976,191 1,976,191 0 0.0%
Sema.BodyInitKindRequest 99,761 99,761 0 0.0%
Sema.BreakTargetRequest 6,936 6,936 0 0.0%
Sema.CXXNamespaceMemberLookup 0 0 0 0.0%
Sema.CallerSideDefaultArgExprRequest 496,997 496,997 0 0.0%
Sema.CheckDistributedFunctionRequest 80 80 0 0.0%
Sema.CheckInconsistentAccessLevelOnImport 59,425 59,425 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 10,438 10,438 0 0.0%
Sema.CheckInconsistentSPIOnlyImportsRequest 59,425 59,425 0 0.0%
Sema.CheckInconsistentWeakLinkedImportsRequest 10,438 10,438 0 0.0%
Sema.CheckRedeclarationRequest 2,442,886 2,442,886 0 0.0%
Sema.ClangCategoryLookupRequest 0 0 0 0.0%
Sema.ClangDirectLookupRequest 20,091 20,091 0 0.0%
Sema.ClangRecordMemberLookup 20,091 20,091 0 0.0%
Sema.ClassAncestryFlagsRequest 154,430 154,409 -21 -0.01%
Sema.ClosureEffectsRequest 156,695 156,695 0 0.0%
Sema.ClosureHasExplicitResultRequest 60,162 60,162 0 0.0%
Sema.CollectOverriddenDeclsRequest 15,689,588 15,653,894 -35,694 -0.23%
Sema.CompareDeclSpecializationRequest 894,021 893,705 -316 -0.04%
Sema.CompilerPluginLoadRequest 4 4 0 0.0%
Sema.ConditionalRequirementsRequest 907,385 907,231 -154 -0.02%
Sema.ConformanceHasEffectRequest 63 63 0 0.0%
Sema.ConstantValueInfoRequest 0 0 0 0.0%
Sema.ContinueTargetRequest 2,293 2,293 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 23,346 23,346 0 0.0%
Sema.CustomAttrTypeRequest 3,690 3,690 0 0.0%
Sema.CustomRefCountingOperation 0 0 0 0.0%
Sema.CxxRecordAsSwiftType 0 0 0 0.0%
Sema.CxxRecordSemantics 71,740 71,683 -57 -0.08%
Sema.DefaultAndMaxAccessLevelRequest 126,031 126,031 0 0.0%
Sema.DefaultArgumentExprRequest 111,428 111,428 0 0.0%
Sema.DefaultArgumentInitContextRequest 884 884 0 0.0%
Sema.DefaultArgumentTypeRequest 22,160 22,160 0 0.0%
Sema.DefaultDefinitionTypeRequest 8,661 8,661 0 0.0%
Sema.DefaultTypeRequest 678,156 678,156 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 86,228,503 86,215,902 -12,600 -0.01%
Sema.DirectOperatorLookupRequest 2,582,482 2,582,492 9 0.0%
Sema.DirectPrecedenceGroupLookupRequest 958,440 958,440 0 0.0%
Sema.DistributedModuleIsAvailableRequest 67 67 0 0.0%
Sema.DynamicallyReplacedDeclRequest 7,755,025 7,755,029 4 0.0%
Sema.EnumElementExprPatternRequest 19 19 0 0.0%
Sema.EnumRawTypeRequest 43,017 43,017 0 0.0%
Sema.EnumRawValuesRequest 25,233 25,233 0 0.0%
Sema.ExistentialConformsToSelfRequest 34,301 34,298 -2 -0.01%
Sema.ExpandAccessorMacros 1,103,822 1,103,822 0 0.0%
Sema.ExpandChildTypeRefinementContextsRequest 729,018 729,018 0 0.0%
Sema.ExpandExtensionMacros 1,075,047 1,074,291 -756 -0.07%
Sema.ExpandMacroExpansionDeclRequest 0 0 0 0.0%
Sema.ExpandMacroExpansionExprRequest 0 0 0 0.0%
Sema.ExpandMemberAttributeMacros 70,751,317 70,663,672 -87,645 -0.12%
Sema.ExpandPeerMacroRequest 50,739,775 50,646,519 -93,256 -0.18%
Sema.ExpandSynthesizedMemberMacroRequest 317,629 317,628 -1 -0.0%
Sema.ExprPatternMatchRequest 99,191 99,191 0 0.0%
Sema.ExtendedNominalRequest 735,672 735,672 0 0.0%
Sema.ExtendedTypeRequest 226,872 226,871 -1 -0.0%
Sema.ExternalMacroDefinitionRequest 4 4 0 0.0%
Sema.FragileFunctionKindRequest 2,906,558 2,906,558 0 0.0%
Sema.FunctionOperatorRequest 20,626 20,626 0 0.0%
Sema.GenericParamListRequest 7,486,945 7,484,854 -2,091 -0.03%
Sema.GenericSignatureRequest 3,697,971 3,697,492 -479 -0.01%
Sema.GetDestructorRequest 47,356 47,356 0 0.0%
Sema.GetDistributedActorArgumentDecodingMethodRequest 19 19 0 0.0%
Sema.GetDistributedActorIDPropertyRequest 72 72 0 0.0%
Sema.GetDistributedActorImplicitCodableRequest 117 117 0 0.0%
Sema.GetDistributedActorInvocationDecoderRequest 19 19 0 0.0%
Sema.GetDistributedActorSystemPropertyRequest 63 63 0 0.0%
Sema.GetDistributedActorSystemRemoteCallFunctionRequest 46 46 0 0.0%
Sema.GetDistributedRemoteCallArgumentInitFunctionRequest 19 19 0 0.0%
Sema.GetDistributedRemoteCallTargetInitFunctionRequest 19 19 0 0.0%
Sema.GetDistributedTargetInvocationDecoderDecodeNextArgumentFunctionRequest 22 22 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordArgumentFunctionRequest 20 20 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordErrorTypeFunctionRequest 11 11 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordReturnTypeFunctionRequest 16 16 0 0.0%
Sema.GetDistributedTargetInvocationResultHandlerOnReturnFunctionRequest 12 12 0 0.0%
Sema.GetDistributedThunkRequest 80 80 0 0.0%
Sema.GetImplicitSendableRequest 267,566 267,530 -36 -0.01%
Sema.GetRuntimeDiscoverableAttributes 2,568,591 2,568,591 0 0.0%
Sema.GetSourceFileAsyncNode 138 138 0 0.0%
Sema.GlobalActorAttributeRequest 9,241,326 9,241,423 96 0.0%
Sema.GlobalActorInstanceRequest 1,127 1,127 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 18,995 18,995 0 0.0%
Sema.HasCircularRawValueRequest 26,138 26,138 0 0.0%
Sema.HasDefaultInitRequest 110,855 110,855 0 0.0%
Sema.HasDynamicCallableAttributeRequest 32,472 32,472 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 589,561 589,475 -86 -0.01%
Sema.HasImportsMatchingFlagRequest 738,291 738,291 0 0.0%
Sema.HasInitAccessorRequest 5,712,250 5,704,615 -7,634 -0.13%
Sema.HasIsolatedSelfRequest 16,433,774 16,423,084 -10,690 -0.07%
Sema.HasMemberwiseInitRequest 55,871 55,871 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 33,552 33,552 0 0.0%
Sema.HasSelfOrAssociatedTypeRequirementsRequest 17,000 17,000 0 0.0%
Sema.HasStorageRequest 2,421,260 2,421,260 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 110,865 110,865 0 0.0%
Sema.IDEInspectionFileRequest 0 0 0 0.0%
Sema.ImplementsAttrProtocolRequest 0 0 0 0.0%
Sema.InferredGenericSignatureRequest 249,111 249,106 -5 -0.0%
Sema.InheritedDeclsReferencedRequest 7,959,280 7,952,839 -6,441 -0.08%
Sema.InheritedProtocolsRequest 854,085 853,972 -113 -0.01%
Sema.InheritedTypeRequest 490,805 490,752 -53 -0.01%
Sema.InheritsSuperclassInitializersRequest 42,507 42,507 0 0.0%
Sema.InitAccessorPropertiesRequest 51,595 51,595 0 0.0%
Sema.InitAccessorReferencedVariablesRequest 0 0 0 0.0%
Sema.InitKindRequest 208,613 208,613 0 0.0%
Sema.InterfaceTypeRequest 24,969,279 24,942,574 -26,704 -0.11%
Sema.IsABICompatibleOverrideRequest 342,697 342,697 0 0.0%
Sema.IsAccessorTransparentRequest 614,257 614,257 0 0.0%
Sema.IsActorRequest 2,518,088 2,517,344 -743 -0.03%
Sema.IsCallAsFunctionNominalRequest 7,010 7,010 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 72,592 72,592 0 0.0%
Sema.IsDefaultActorRequest 64,423 64,423 0 0.0%
Sema.IsDistributedActorRequest 2,811,633 2,810,788 -845 -0.03%
Sema.IsDynamicRequest 3,458,005 3,458,005 0 0.0%
Sema.IsFinalRequest 5,212,484 5,208,060 -4,424 -0.08%
Sema.IsGetterMutatingRequest 870,727 870,727 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 4,241,968 4,241,642 -326 -0.01%
Sema.IsMoveOnlyRequest 798,260 798,219 -41 -0.01%
Sema.IsNonUserModuleRequest 103,411 103,426 14 0.01%
Sema.IsObjCRequest 3,210,192 3,209,913 -279 -0.01%
Sema.IsSafeUseOfCxxDecl 0 0 0 0.0%
Sema.IsSetterMutatingRequest 781,870 781,870 0 0.0%
Sema.IsSingleValueStmtRequest 396,658 396,658 0 0.0%
Sema.IsStaticRequest 1,732,872 1,732,825 -46 -0.0%
Sema.LazyStoragePropertyRequest 2,585 2,585 0 0.0%
Sema.LocalDiscriminatorsRequest 586,811 586,811 0 0.0%
Sema.LookupAllConformancesInContextRequest 3,232,963 3,227,905 -5,057 -0.16%
Sema.LookupConformanceInModuleRequest 130,256,850 130,213,759 -43,091 -0.03%
Sema.LookupInModuleRequest 10,040,223 10,039,891 -332 -0.0%
Sema.LookupInfixOperatorRequest 83,413 83,413 0 0.0%
Sema.LookupPostfixOperatorRequest 74 74 0 0.0%
Sema.LookupPrecedenceGroupRequest 34,012 34,012 0 0.0%
Sema.LookupPrefixOperatorRequest 454 454 0 0.0%
Sema.MacroDefinitionRequest 8 8 0 0.0%
Sema.MangleLocalTypeDeclRequest 3,192 3,192 0 0.0%
Sema.MemberwiseInitPropertiesRequest 51,597 51,597 0 0.0%
Sema.ModuleImplicitImportsRequest 10,438 10,438 0 0.0%
Sema.ModuleLibraryLevelRequest 22 22 0 0.0%
Sema.ModuleQualifiedLookupRequest 3,778,255 3,778,116 -139 -0.0%
Sema.NamedLazyMemberLoadSuccessCount 66,273,580 66,274,012 432 0.0%
Sema.NamingPatternRequest 254,300 254,299 -1 -0.0%
Sema.NeedsNewVTableEntryRequest 1,113,232 1,113,232 0 0.0%
Sema.NumAccessorBodiesSynthesized 496,497 496,497 0 0.0%
Sema.NumAccessorsSynthesized 598,092 598,092 0 0.0%
Sema.NumConformancePathsRecorded 1,014,190 1,014,198 8 0.0%
Sema.NumConformancesDeserialized 6,299,672 6,294,709 -4,963 -0.08%
Sema.NumConstraintScopes 79,294,610 79,293,320 -1,290 -0.0%
Sema.NumConstraintsConsideredForEdgeContraction 2,814,275 2,814,275 0 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 98,657,255 98,571,398 -85,856 -0.09%
Sema.NumDeclsTypechecked 3,471,318 3,471,318 0 0.0%
Sema.NumLazyIterableDeclContexts 14,761,459 14,759,491 -1,968 -0.01%
Sema.NumLazyRequirementSignatures 1,119,685 1,119,655 -30 -0.0%
Sema.NumLazyRequirementSignaturesLoaded 788,067 788,032 -35 -0.0%
Sema.NumLeafScopes 61,099,108 61,098,008 -1,100 -0.0%
Sema.NumRequirementMachineCompletionSteps 27,569,331 27,559,057 -10,274 -0.04%
Sema.NumRequirementMachineUnifiedConcreteTerms 1,364,176 1,366,167 1,991 0.15%
Sema.NumRequirementMachines 2,348,783 2,347,860 -923 -0.04%
Sema.NumTypesDeserialized 27,334,006 27,325,101 -8,904 -0.03%
Sema.NumUnloadedLazyIterableDeclContexts 11,217,117 11,220,827 3,709 0.03%
Sema.ObjCInterfaceAndImplementationRequest 986,392 986,389 -2 -0.0%
Sema.OpaqueReadOwnershipRequest 531,224 531,224 0 0.0%
Sema.OpaqueResultTypeRequest 690 690 0 0.0%
Sema.OperatorPrecedenceGroupRequest 1,027 1,027 0 0.0%
Sema.OverriddenDeclsRequest 6,849,788 6,846,746 -3,042 -0.04%
Sema.ParamSpecifierRequest 2,354,073 2,354,072 -1 -0.0%
Sema.PatternBindingEntryRequest 859,497 859,496 -1 -0.0%
Sema.PatternTypeRequest 1,016,898 1,016,897 -1 -0.0%
Sema.PolymorphicEffectKindRequest 1,154,364 1,154,364 0 0.0%
Sema.PolymorphicEffectRequirementsRequest 75 75 0 0.0%
Sema.PotentialMacroExpansionsInContextRequest 7,479,401 7,479,200 -201 -0.0%
Sema.PreCheckFunctionBodyRequest 465,846 465,846 0 0.0%
Sema.PreCheckResultBuilderRequest 1,169 1,169 0 0.0%
Sema.PreCheckReturnStmtRequest 633,096 633,096 0 0.0%
Sema.PrimaryAssociatedTypesRequest 20,011 19,988 -23 -0.11%
Sema.PrimarySourceFilesRequest 10,438 10,438 0 0.0%
Sema.PropertyWrapperAuxiliaryVariablesRequest 2,582,256 2,582,256 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 33,130 33,130 0 0.0%
Sema.PropertyWrapperInitializerInfoRequest 754,874 754,874 0 0.0%
Sema.PropertyWrapperLValuenessRequest 2,839 2,839 0 0.0%
Sema.PropertyWrapperMutabilityRequest 863,641 863,641 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 651 651 0 0.0%
Sema.ProtocolDependenciesRequest 677,061 676,976 -85 -0.01%
Sema.ProtocolRequirementsRequest 83,323 83,322 -1 -0.0%
Sema.ProtocolRequiresClassRequest 48,897 48,830 -67 -0.14%
Sema.ProvideDefaultImplForRequest 15,689,588 15,653,894 -35,694 -0.23%
Sema.QualifiedLookupRequest 10,489,283 10,487,194 -2,088 -0.02%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RawCommentRequest 1,268,502 1,268,502 0 0.0%
Sema.RenamedDeclRequest 5,542 5,542 0 0.0%
Sema.RequirementRequest 197,549 197,548 -1 -0.0%
Sema.RequirementSignatureRequest 848,543 848,454 -89 -0.01%
Sema.RequiresOpaqueAccessorsRequest 2,199,679 2,199,679 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 534,023 534,023 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveExtensionMacroConformances 8 8 0 0.0%
Sema.ResolveImplicitMemberRequest 1,041,145 1,040,889 -256 -0.02%
Sema.ResolveMacroRequest 27,328 27,340 12 0.04%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveRawLayoutLikeTypeRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 5,974,385 5,974,362 -23 -0.0%
Sema.ResultBuilderTypeRequest 590,598 590,598 0 0.0%
Sema.ResultTypeRequest 1,317,278 1,317,275 -3 -0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 8,873,557 8,871,149 -2,408 -0.03%
Sema.ScopedImportLookupRequest 918 918 0 0.0%
Sema.SelfAccessKindRequest 1,099,522 1,099,481 -40 -0.0%
Sema.SelfBoundsFromGenericSignatureRequest 94,444 94,444 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 2,060,451 2,059,212 -1,239 -0.06%
Sema.SemanticAvailableRangeAttrRequest 10,154 10,154 0 0.0%
Sema.SemanticBriefCommentRequest 206,467 206,467 0 0.0%
Sema.SemanticUnavailableAttrRequest 3,094,360 3,094,360 0 0.0%
Sema.SetterAccessLevelRequest 300,415 300,415 0 0.0%
Sema.SimpleDidSetRequest 3,868,915 3,861,257 -7,658 -0.2%
Sema.SpecializeAttrTargetDeclRequest 3,181 3,181 0 0.0%
Sema.StorageImplInfoRequest 2,195,447 2,195,447 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 73,663 73,663 0 0.0%
Sema.StoredPropertiesRequest 437,896 437,891 -4 -0.0%
Sema.StructuralRequirementsRequest 60,670 60,616 -54 -0.09%
Sema.StructuralTypeRequest 2,186 2,186 0 0.0%
Sema.SuperclassDeclRequest 581,829 581,724 -105 -0.02%
Sema.SuperclassTypeRequest 74,724 74,724 0 0.0%
Sema.SynthesizeAccessorRequest 598,092 598,092 0 0.0%
Sema.SynthesizeDefaultInitRequest 14,150 14,150 0 0.0%
Sema.SynthesizeMainFunctionRequest 277,360 277,358 -1 -0.0%
Sema.SynthesizeMemberwiseInitRequest 12,024 12,024 0 0.0%
Sema.SynthesizeRuntimeMetadataAttrGenerator 0 0 0 0.0%
Sema.SynthesizeRuntimeMetadataAttrGeneratorBody 0 0 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeAliasRequirementsRequest 60,670 60,616 -54 -0.09%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 1,077,777 1,077,777 0 0.0%
Sema.TypeCheckObjCImplementationRequest 0 0 0 0.0%
Sema.TypeCheckSourceFileRequest 59,425 59,425 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 61,376 61,376 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 19,147 19,146 -1 -0.01%
Sema.USRGenerationRequest 17,500,445 17,464,466 -35,979 -0.21%
Sema.UnderlyingTypeDeclsReferencedRequest 379,492 379,081 -411 -0.11%
Sema.UnderlyingTypeRequest 62,384 62,383 0 -0.0%
Sema.UnqualifiedLookupRequest 7,535,120 7,534,919 -200 -0.0%
Sema.ValidatePrecedenceGroupRequest 283,284 283,284 0 0.0%
Sema.ValueWitnessRequest 83,059 83,059 0 0.0%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 29,465 29,465 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 107,097,653,708,727 107,068,639,338,816 -29,014,369,911 -0.03%
LLVM.NumLLVMBytesOutput 2,208,763,128 2,208,837,916 74,788 0.0%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
AST.NumSourceLinesPerSecond 321,529 317,564 -3,965 -1.23% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (331)
name old new delta delta_pct
AST.ImportSetCacheHit 1,750,158 1,750,158 0 0.0%
AST.ImportSetCacheMiss 85,007 85,007 0 0.0%
AST.ImportSetFoldHit 45,035 45,035 0 0.0%
AST.ImportSetFoldMiss 39,972 39,972 0 0.0%
AST.ModuleShadowCacheHit 5,022 5,022 0 0.0%
AST.ModuleShadowCacheMiss 1,432 1,432 0 0.0%
AST.ModuleVisibilityCacheHit 13,532,434 13,532,434 0 0.0%
AST.ModuleVisibilityCacheMiss 40,198 40,198 0 0.0%
AST.NumASTBytesAllocated 11,505,501,519 11,505,505,367 3,848 0.0%
AST.NumASTScopeExpansions 3,792,476 3,792,476 0 0.0%
AST.NumASTScopeLookups 5,220,754 5,220,754 0 0.0%
AST.NumDecls 183,414 183,414 0 0.0%
AST.NumDependencies 56,087 56,087 0 0.0%
AST.NumIncrementalDependencies 58 58 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 31,227 31,227 0 0.0%
AST.NumLocalTypeDecls 321 321 0 0.0%
AST.NumModuleLookupClassMember 6,680 6,680 0 0.0%
AST.NumModuleLookupValue 40,602,435 40,602,435 0 0.0%
AST.NumObjCMethods 19,496 19,496 0 0.0%
AST.NumOperators 515 515 0 0.0%
AST.NumPrecedenceGroups 90 90 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedMemberNames 4,434 4,434 0 0.0%
AST.NumReferencedTopLevelNames 352 352 0 0.0%
AST.NumSourceBuffers 38,146 38,146 0 0.0%
AST.NumSourceLines 6,386,668 6,386,668 0 0.0%
AST.NumTotalClangImportedEntities 452,810 452,810 0 0.0%
Frontend.MaxMallocUsage 0 0 0 0.0%
Frontend.NumInstructionsExecuted 107,097,653,708,727 107,068,639,338,816 -29,014,369,911 -0.03%
Frontend.NumProcessFailures 2 2 0 0.0%
IRGen.IRGenRequest 12 12 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 270,827 270,827 0 0.0%
IRModule.NumIRAliases 164,734 164,734 0 0.0%
IRModule.NumIRBasicBlocks 5,880,212 5,880,212 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,145,651 3,145,651 0 0.0%
IRModule.NumIRGlobals 3,521,537 3,521,537 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 47,250,229 47,250,229 0 0.0%
IRModule.NumIRNamedMetaData 115,072 115,072 0 0.0%
IRModule.NumIRValueSymbols 6,678,893 6,678,893 0 0.0%
LLVM.NumLLVMBytesOutput 2,208,763,128 2,208,837,916 74,788 0.0%
Parse.ExportedSourceFileRequest 2 2 0 0.0%
Parse.IDEInspectionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 349,383 349,383 0 0.0%
Parse.NumIterableDeclContextParsed 132,043 132,043 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 337,817 337,817 0 0.0%
Parse.ParseMembersRequest 14,394 14,394 0 0.0%
Parse.ParseSourceFileRequest 33,358 33,358 0 0.0%
Parse.ParseTopLevelDeclsRequest 33,358 33,358 0 0.0%
SILGen.ASTLoweringRequest 1,281 1,281 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 830 830 0 0.0%
SILModule.NumSILGenFunctions 1,479,059 1,479,059 0 0.0%
SILModule.NumSILGenGlobalVariables 68,070 68,070 0 0.0%
SILModule.NumSILGenVtables 24,106 24,106 0 0.0%
SILModule.NumSILGenWitnessTables 94,999 94,999 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 830 830 0 0.0%
SILModule.NumSILOptFunctions 1,255,073 1,255,073 0 0.0%
SILModule.NumSILOptGlobalVariables 49,623 49,623 0 0.0%
SILModule.NumSILOptVtables 28,446 28,446 0 0.0%
SILModule.NumSILOptWitnessTables 95,516 95,516 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 6,301 6,301 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 140,208 140,208 0 0.0%
Sema.AbstractGenericSignatureRequest 75,401 75,401 0 0.0%
Sema.AccessLevelRequest 2,054,449 2,054,449 0 0.0%
Sema.ActorIsolationRequest 2,299,289 2,299,289 0 0.0%
Sema.AllMembersRequest 124,093 124,093 0 0.0%
Sema.AnyObjectLookupRequest 236 236 0 0.0%
Sema.ApplyAccessNoteRequest 2,202,659 2,202,659 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 20,834 20,834 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 9,633 9,633 0 0.0%
Sema.AttachedPropertyWrappersRequest 4,054,907 4,054,907 0 0.0%
Sema.AttachedResultBuilderRequest 1,066,689 1,066,689 0 0.0%
Sema.BodyInitKindRequest 58,660 58,660 0 0.0%
Sema.BreakTargetRequest 5,676 5,676 0 0.0%
Sema.CXXNamespaceMemberLookup 0 0 0 0.0%
Sema.CallerSideDefaultArgExprRequest 148,182 148,182 0 0.0%
Sema.CheckDistributedFunctionRequest 42 42 0 0.0%
Sema.CheckInconsistentAccessLevelOnImport 33,334 33,334 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 1,283 1,283 0 0.0%
Sema.CheckInconsistentSPIOnlyImportsRequest 33,334 33,334 0 0.0%
Sema.CheckInconsistentWeakLinkedImportsRequest 1,283 1,283 0 0.0%
Sema.CheckRedeclarationRequest 1,303,070 1,303,070 0 0.0%
Sema.ClangCategoryLookupRequest 0 0 0 0.0%
Sema.ClangDirectLookupRequest 13,266 13,266 0 0.0%
Sema.ClangRecordMemberLookup 13,266 13,266 0 0.0%
Sema.ClassAncestryFlagsRequest 56,290 56,290 0 0.0%
Sema.ClosureEffectsRequest 109,559 109,559 0 0.0%
Sema.ClosureHasExplicitResultRequest 36,692 36,692 0 0.0%
Sema.CollectOverriddenDeclsRequest 20,724 20,724 0 0.0%
Sema.CompareDeclSpecializationRequest 487,712 487,712 0 0.0%
Sema.CompilerPluginLoadRequest 2 2 0 0.0%
Sema.ConditionalRequirementsRequest 240,328 240,328 0 0.0%
Sema.ConformanceHasEffectRequest 44 44 0 0.0%
Sema.ConstantValueInfoRequest 0 0 0 0.0%
Sema.ContinueTargetRequest 2,005 2,005 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 8,493 8,493 0 0.0%
Sema.CustomAttrTypeRequest 868 868 0 0.0%
Sema.CustomRefCountingOperation 0 0 0 0.0%
Sema.CxxRecordAsSwiftType 0 0 0 0.0%
Sema.CxxRecordSemantics 17,930 17,930 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 59,485 59,485 0 0.0%
Sema.DefaultArgumentExprRequest 55,541 55,541 0 0.0%
Sema.DefaultArgumentInitContextRequest 147 147 0 0.0%
Sema.DefaultArgumentTypeRequest 8,610 8,610 0 0.0%
Sema.DefaultDefinitionTypeRequest 3,634 3,634 0 0.0%
Sema.DefaultTypeRequest 319,500 319,500 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 109,814,495 109,815,036 540 0.0%
Sema.DirectOperatorLookupRequest 1,683,058 1,683,058 0 0.0%
Sema.DirectPrecedenceGroupLookupRequest 690,341 690,341 0 0.0%
Sema.DistributedModuleIsAvailableRequest 33 33 0 0.0%
Sema.DynamicallyReplacedDeclRequest 2,510,692 2,510,692 0 0.0%
Sema.EnumElementExprPatternRequest 12 12 0 0.0%
Sema.EnumRawTypeRequest 11,825 11,825 0 0.0%
Sema.EnumRawValuesRequest 11,854 11,854 0 0.0%
Sema.ExistentialConformsToSelfRequest 6,813 6,813 0 0.0%
Sema.ExpandAccessorMacros 636,330 636,330 0 0.0%
Sema.ExpandChildTypeRefinementContextsRequest 405,010 405,010 0 0.0%
Sema.ExpandExtensionMacros 143,612 143,612 0 0.0%
Sema.ExpandMacroExpansionDeclRequest 0 0 0 0.0%
Sema.ExpandMacroExpansionExprRequest 0 0 0 0.0%
Sema.ExpandMemberAttributeMacros 9,082,896 9,082,896 0 0.0%
Sema.ExpandPeerMacroRequest 3,619,499 3,619,499 0 0.0%
Sema.ExpandSynthesizedMemberMacroRequest 129,587 129,587 0 0.0%
Sema.ExprPatternMatchRequest 58,041 58,041 0 0.0%
Sema.ExtendedNominalRequest 65,713 65,713 0 0.0%
Sema.ExtendedTypeRequest 65,488 65,488 0 0.0%
Sema.ExternalMacroDefinitionRequest 2 2 0 0.0%
Sema.FragileFunctionKindRequest 1,242,995 1,242,995 0 0.0%
Sema.FunctionOperatorRequest 9,865 9,865 0 0.0%
Sema.GenericParamListRequest 1,780,415 1,780,415 0 0.0%
Sema.GenericSignatureRequest 1,257,222 1,257,222 0 0.0%
Sema.GetDestructorRequest 24,473 24,473 0 0.0%
Sema.GetDistributedActorArgumentDecodingMethodRequest 19 19 0 0.0%
Sema.GetDistributedActorIDPropertyRequest 32 32 0 0.0%
Sema.GetDistributedActorImplicitCodableRequest 56 56 0 0.0%
Sema.GetDistributedActorInvocationDecoderRequest 19 19 0 0.0%
Sema.GetDistributedActorSystemPropertyRequest 28 28 0 0.0%
Sema.GetDistributedActorSystemRemoteCallFunctionRequest 8 8 0 0.0%
Sema.GetDistributedRemoteCallArgumentInitFunctionRequest 5 5 0 0.0%
Sema.GetDistributedRemoteCallTargetInitFunctionRequest 5 5 0 0.0%
Sema.GetDistributedTargetInvocationDecoderDecodeNextArgumentFunctionRequest 5 5 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordArgumentFunctionRequest 5 5 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordErrorTypeFunctionRequest 3 3 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordReturnTypeFunctionRequest 4 4 0 0.0%
Sema.GetDistributedTargetInvocationResultHandlerOnReturnFunctionRequest 1 1 0 0.0%
Sema.GetDistributedThunkRequest 42 42 0 0.0%
Sema.GetImplicitSendableRequest 50,782 50,782 0 0.0%
Sema.GetRuntimeDiscoverableAttributes 1,369,801 1,369,801 0 0.0%
Sema.GetSourceFileAsyncNode 67 67 0 0.0%
Sema.GlobalActorAttributeRequest 3,082,515 3,082,515 0 0.0%
Sema.GlobalActorInstanceRequest 195 195 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 9,299 9,299 0 0.0%
Sema.HasCircularRawValueRequest 11,741 11,741 0 0.0%
Sema.HasDefaultInitRequest 42,867 42,867 0 0.0%
Sema.HasDynamicCallableAttributeRequest 11,993 11,993 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 142,012 142,012 0 0.0%
Sema.HasImportsMatchingFlagRequest 66,254 66,254 0 0.0%
Sema.HasInitAccessorRequest 848,987 848,987 0 0.0%
Sema.HasIsolatedSelfRequest 4,264,197 4,264,197 0 0.0%
Sema.HasMemberwiseInitRequest 18,747 18,747 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 20,617 20,617 0 0.0%
Sema.HasSelfOrAssociatedTypeRequirementsRequest 8,487 8,487 0 0.0%
Sema.HasStorageRequest 1,579,413 1,579,413 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 42,867 42,867 0 0.0%
Sema.IDEInspectionFileRequest 0 0 0 0.0%
Sema.ImplementsAttrProtocolRequest 0 0 0 0.0%
Sema.InferredGenericSignatureRequest 96,628 96,628 0 0.0%
Sema.InheritedDeclsReferencedRequest 1,176,558 1,176,558 0 0.0%
Sema.InheritedProtocolsRequest 118,414 118,414 0 0.0%
Sema.InheritedTypeRequest 226,135 226,135 0 0.0%
Sema.InheritsSuperclassInitializersRequest 19,325 19,325 0 0.0%
Sema.InitAccessorPropertiesRequest 21,414 21,414 0 0.0%
Sema.InitAccessorReferencedVariablesRequest 0 0 0 0.0%
Sema.InitKindRequest 82,506 82,506 0 0.0%
Sema.InterfaceTypeRequest 4,822,011 4,822,011 0 0.0%
Sema.IsABICompatibleOverrideRequest 181,118 181,118 0 0.0%
Sema.IsAccessorTransparentRequest 319,834 319,834 0 0.0%
Sema.IsActorRequest 382,136 382,136 0 0.0%
Sema.IsCallAsFunctionNominalRequest 6,033 6,033 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 33,839 33,839 0 0.0%
Sema.IsDefaultActorRequest 32,186 32,186 0 0.0%
Sema.IsDistributedActorRequest 440,498 440,498 0 0.0%
Sema.IsDynamicRequest 1,646,513 1,646,513 0 0.0%
Sema.IsFinalRequest 1,347,813 1,347,813 0 0.0%
Sema.IsGetterMutatingRequest 432,880 432,880 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,423,912 2,423,912 0 0.0%
Sema.IsMoveOnlyRequest 231,151 231,151 0 0.0%
Sema.IsNonUserModuleRequest 284 284 0 0.0%
Sema.IsObjCRequest 1,462,979 1,462,979 0 0.0%
Sema.IsSafeUseOfCxxDecl 0 0 0 0.0%
Sema.IsSetterMutatingRequest 421,505 421,505 0 0.0%
Sema.IsSingleValueStmtRequest 308,550 308,550 0 0.0%
Sema.IsStaticRequest 728,443 728,443 0 0.0%
Sema.LazyStoragePropertyRequest 584 584 0 0.0%
Sema.LocalDiscriminatorsRequest 362,350 362,350 0 0.0%
Sema.LookupAllConformancesInContextRequest 153,421 153,421 0 0.0%
Sema.LookupConformanceInModuleRequest 75,299,274 75,302,861 3,587 0.0%
Sema.LookupInModuleRequest 3,067,336 3,067,336 0 0.0%
Sema.LookupInfixOperatorRequest 65,096 65,096 0 0.0%
Sema.LookupPostfixOperatorRequest 37 37 0 0.0%
Sema.LookupPrecedenceGroupRequest 28,152 28,152 0 0.0%
Sema.LookupPrefixOperatorRequest 212 212 0 0.0%
Sema.MacroDefinitionRequest 4 4 0 0.0%
Sema.MangleLocalTypeDeclRequest 301 301 0 0.0%
Sema.MemberwiseInitPropertiesRequest 21,414 21,414 0 0.0%
Sema.ModuleImplicitImportsRequest 1,283 1,283 0 0.0%
Sema.ModuleLibraryLevelRequest 107 107 0 0.0%
Sema.ModuleQualifiedLookupRequest 612,928 612,928 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 18,620,348 18,620,348 0 0.0%
Sema.NamingPatternRequest 42,671 42,671 0 0.0%
Sema.NeedsNewVTableEntryRequest 700,431 700,431 0 0.0%
Sema.NumAccessorBodiesSynthesized 262,994 262,994 0 0.0%
Sema.NumAccessorsSynthesized 266,143 266,143 0 0.0%
Sema.NumConformancePathsRecorded 814,381 814,381 0 0.0%
Sema.NumConformancesDeserialized 818,823 818,823 0 0.0%
Sema.NumConstraintScopes 47,427,871 47,427,863 -8 -0.0%
Sema.NumConstraintsConsideredForEdgeContraction 2,283,841 2,283,841 0 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 12,120,033 12,120,033 0 0.0%
Sema.NumDeclsTypechecked 1,868,638 1,868,638 0 0.0%
Sema.NumLazyIterableDeclContexts 2,021,041 2,021,041 0 0.0%
Sema.NumLazyRequirementSignatures 146,430 146,430 0 0.0%
Sema.NumLazyRequirementSignaturesLoaded 108,520 108,520 0 0.0%
Sema.NumLeafScopes 36,277,884 36,277,878 -5 -0.0%
Sema.NumRequirementMachineCompletionSteps 4,066,972 4,066,972 0 0.0%
Sema.NumRequirementMachineUnifiedConcreteTerms 331,245 331,245 0 0.0%
Sema.NumRequirementMachines 375,916 375,916 0 0.0%
Sema.NumTypesDeserialized 5,463,176 5,463,176 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 1,872,378 1,872,378 0 0.0%
Sema.ObjCInterfaceAndImplementationRequest 563,893 563,893 0 0.0%
Sema.OpaqueReadOwnershipRequest 234,646 234,646 0 0.0%
Sema.OpaqueResultTypeRequest 242 242 0 0.0%
Sema.OperatorPrecedenceGroupRequest 448 448 0 0.0%
Sema.OverriddenDeclsRequest 1,640,617 1,640,617 0 0.0%
Sema.ParamSpecifierRequest 1,054,676 1,054,676 0 0.0%
Sema.PatternBindingEntryRequest 377,175 377,175 0 0.0%
Sema.PatternTypeRequest 488,733 488,733 0 0.0%
Sema.PolymorphicEffectKindRequest 604,941 604,941 0 0.0%
Sema.PolymorphicEffectRequirementsRequest 31 31 0 0.0%
Sema.PotentialMacroExpansionsInContextRequest 1,382,604 1,382,604 0 0.0%
Sema.PreCheckFunctionBodyRequest 356,906 356,906 0 0.0%
Sema.PreCheckResultBuilderRequest 575 575 0 0.0%
Sema.PreCheckReturnStmtRequest 499,774 499,774 0 0.0%
Sema.PrimaryAssociatedTypesRequest 7,892 7,892 0 0.0%
Sema.PrimarySourceFilesRequest 1,283 1,283 0 0.0%
Sema.PropertyWrapperAuxiliaryVariablesRequest 1,635,212 1,635,212 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 9,633 9,633 0 0.0%
Sema.PropertyWrapperInitializerInfoRequest 420,528 420,528 0 0.0%
Sema.PropertyWrapperLValuenessRequest 737 737 0 0.0%
Sema.PropertyWrapperMutabilityRequest 430,534 430,534 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 124 124 0 0.0%
Sema.ProtocolDependenciesRequest 98,122 98,122 0 0.0%
Sema.ProtocolRequirementsRequest 19,639 19,639 0 0.0%
Sema.ProtocolRequiresClassRequest 9,707 9,707 0 0.0%
Sema.ProvideDefaultImplForRequest 20,724 20,724 0 0.0%
Sema.QualifiedLookupRequest 4,983,754 4,983,754 0 0.0%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RawCommentRequest 612,168 612,168 0 0.0%
Sema.RenamedDeclRequest 3,308 3,308 0 0.0%
Sema.RequirementRequest 97,258 97,258 0 0.0%
Sema.RequirementSignatureRequest 119,649 119,649 0 0.0%
Sema.RequiresOpaqueAccessorsRequest 1,485,424 1,485,424 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 234,753 234,753 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveExtensionMacroConformances 4 4 0 0.0%
Sema.ResolveImplicitMemberRequest 521,898 521,898 0 0.0%
Sema.ResolveMacroRequest 12,911 12,911 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveRawLayoutLikeTypeRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 2,610,448 2,610,448 0 0.0%
Sema.ResultBuilderTypeRequest 417,747 417,747 0 0.0%
Sema.ResultTypeRequest 537,480 537,480 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 2,393,389 2,393,389 0 0.0%
Sema.ScopedImportLookupRequest 446 446 0 0.0%
Sema.SelfAccessKindRequest 404,710 404,710 0 0.0%
Sema.SelfBoundsFromGenericSignatureRequest 31,637 31,637 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 538,906 538,906 0 0.0%
Sema.SemanticAvailableRangeAttrRequest 4,893 4,893 0 0.0%
Sema.SemanticBriefCommentRequest 188,823 188,823 0 0.0%
Sema.SemanticUnavailableAttrRequest 1,277,162 1,277,162 0 0.0%
Sema.SetterAccessLevelRequest 192,555 192,555 0 0.0%
Sema.SimpleDidSetRequest 433,066 433,066 0 0.0%
Sema.SpecializeAttrTargetDeclRequest 19,656 19,656 0 0.0%
Sema.StorageImplInfoRequest 1,503,208 1,503,208 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 46,002 46,002 0 0.0%
Sema.StoredPropertiesRequest 153,521 153,521 0 0.0%
Sema.StructuralRequirementsRequest 11,149 11,149 0 0.0%
Sema.StructuralTypeRequest 611 611 0 0.0%
Sema.SuperclassDeclRequest 109,588 109,588 0 0.0%
Sema.SuperclassTypeRequest 30,569 30,569 0 0.0%
Sema.SynthesizeAccessorRequest 266,143 266,143 0 0.0%
Sema.SynthesizeDefaultInitRequest 3,518 3,518 0 0.0%
Sema.SynthesizeMainFunctionRequest 128,919 128,919 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,534 3,534 0 0.0%
Sema.SynthesizeRuntimeMetadataAttrGenerator 0 0 0 0.0%
Sema.SynthesizeRuntimeMetadataAttrGeneratorBody 0 0 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeAliasRequirementsRequest 11,149 11,149 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 677,195 677,195 0 0.0%
Sema.TypeCheckObjCImplementationRequest 0 0 0 0.0%
Sema.TypeCheckSourceFileRequest 33,334 33,334 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 33,516 33,516 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 5,772 5,772 0 0.0%
Sema.USRGenerationRequest 471,821 471,821 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 57,967 57,967 0 0.0%
Sema.UnderlyingTypeRequest 29,292 29,292 0 0.0%
Sema.UnqualifiedLookupRequest 3,038,078 3,038,078 0 0.0%
Sema.ValidatePrecedenceGroupRequest 226,934 226,934 0 0.0%
Sema.ValueWitnessRequest 37,191 37,191 0 0.0%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 1,229 1,229 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

@hamishknight
Copy link
Contributor Author

A little concerned about the regression of SourceLinesPerSecond (incorrectly listed as an improvement), seems like more than just noise...

@xedin
Copy link
Contributor

xedin commented Aug 10, 2023

I know that MovieSwift is flaky and there are UPASSes there too, you can check individual project status to check where this is coming from.

@hamishknight
Copy link
Contributor Author

The two runs seem pretty consistent, there are some sporadic UPASSes, but they're the same across both runs:

 UPASS: https://github.com/apple/swift/issues/57431, siesta, 5.0, cb9c1b, Swift Package
 UPASS: https://github.com/apple/swift/issues/57431, Nimble, 5.0, eea584, Swift Package

 UPASS: https://github.com/apple/swift/issues/65203, MovieSwift, 5.0, 237010, MovieSwift, generic/platform=iOS
 UPASS: https://github.com/apple/swift/issues/57431, siesta, 5.0, cb9c1b, Swift Package
 UPASS: https://github.com/apple/swift/issues/57431, Nimble, 5.0, eea584, Swift Package

@hamishknight
Copy link
Contributor Author

hamishknight commented Aug 10, 2023 •
edited
Loading

Running a baseline on #58827 to see whether we have an inherent slowdown for the first run (e.g maybe we're loading modules or something that gets cached for the second run, I would assume we'd nuke the workspace between runs tho). And yeah I'll download the logs and start seeing if it's specific to a given project.

@xedin
Copy link
Contributor

xedin commented Aug 10, 2023

Sounds good!

@hamishknight
Copy link
Contributor Author

Baseline test also showed a 1% regression in NumSourceLinesPerSecond, despite not having any changes. Testing locally, it seems this counter is just flakey and unreliable.

@hamishknight hamishknight merged commit 1ef4f80 into swiftlang:main Aug 11, 2023
@hamishknight hamishknight deleted the conjunction-order branch August 11, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishknight @xedin