[Macros] Always consider pre-macro-expansion conformances as subsumed by other conformance entry kinds, before considering availability. #67882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
other conformance entry kinds, before considering availability.
|
@swift-ci please smoke test |
slavapestov
approved these changes
Aug 11, 2023
This was referenced Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if an explicit conformance (in a macro expansion buffer) is less available than the pre-expansion conformance (which doesn't have any representation of its availability), we'll pick the placeholder conformance and later on drop the conformance on the floor in serialization or SILGen because the placeholder conformance is (deliberately) not complete.
Resolves rdar://113569289