Skip to content

Always forward subcommand invocations to swift-driver #69800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Nov 12, 2023

Companion to swiftlang/swift-driver#1482

Forward all invocations of subcommands like swift package, swift build, etc. to the new driver for handling so it only needs to be implemented once.

@owenv owenv requested review from nkcsgexi and artemcm November 12, 2023 02:17
@owenv
Copy link
Contributor Author

owenv commented Nov 12, 2023

@swift-ci please test

@owenv
Copy link
Contributor Author

owenv commented Nov 12, 2023

/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift run --package-path /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift-syntax/SwiftSyntaxDevUtils swift-syntax-dev-utils verify-source-code --toolchain /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr --verbose
error: unable to find swift-driver to invoke subcommand

This might need to keep some sort of fallback for now

@owenv
Copy link
Contributor Author

owenv commented Nov 15, 2023

Talked to @artemcm and I think #69834 (comment) is the better long-term direction

@owenv owenv closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants