-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[IRGen] Don't call objc_retainAutoreleasedReturnValue() without interop. #72011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#define CF_BRIDGED_TYPE(T) __attribute__((objc_bridge(T))) | ||
|
||
typedef struct CF_BRIDGED_TYPE(id) __CFBridgedType *CFBridgedTypeRef; | ||
|
||
__attribute__((cf_audited_transfer)) | ||
CFBridgedTypeRef returnsACFBridgedType(void); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// RUN: %target-swift-frontend -module-name cf_objc_retainAutoreleasedReturnValue -I %S/Inputs %s -enable-objc-interop -emit-ir | %FileCheck %s | ||
|
||
// We need to require objc_codegen to avoid this test on WASM. | ||
// (That's why the other half of this test is in a separate file.) | ||
al45tair marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
// REQUIRES: objc_codegen | ||
|
||
import CFBridgedType | ||
|
||
@inline(never) | ||
public func foo() { | ||
let _ = returnsACFBridgedType() | ||
} | ||
|
||
// With interop enabled, this should use objc_retainAutoreleasedReturnValue() | ||
|
||
// CHECK-LABEL: define {{.*}}swiftcc void @"$s37cf_objc_retainAutoreleasedReturnValue3fooyyF"() | ||
// CHECK: entry: | ||
// CHECK: %0 = call {{.*}}@returnsACFBridgedType() | ||
// CHECK: %1 = notail call ptr @llvm.objc.retainAutoreleasedReturnValue(ptr %0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// RUN: %target-swift-frontend -module-name cf_objc_retainAutoreleasedReturnValue -I %S/Inputs %s -disable-objc-interop -emit-ir | %FileCheck %s | ||
|
||
// This is in a separate file because *this* one works on WASM. | ||
// (cf_objc_retainAutoreleasedReturnValue.swift does not.) | ||
|
||
import CFBridgedType | ||
|
||
@inline(never) | ||
public func foo() { | ||
let _ = returnsACFBridgedType() | ||
} | ||
|
||
// With interop disabled, this should use swift_retain(). | ||
|
||
// CHECK-LABEL: define {{.*}}swiftcc void @"$s37cf_objc_retainAutoreleasedReturnValue3fooyyF"() | ||
// CHECK: entry: | ||
// CHECK: %0 = call {{.*}}@returnsACFBridgedType() | ||
// CHECK: %1 = call ptr @swift_retain(ptr returned %0) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.