Use new noncopyable types infrastructure #72276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
force-pushed
the
ncgenerics-xfails-3
branch
from
71b256d to
583fc22
Compare
|
@swift-ci smoke test |
kavon
force-pushed
the
ncgenerics-xfails-3
branch
2 times, most recently
from
43a41d0 to
6151882
Compare
|
swiftlang/llvm-project#8384 |
kavon
force-pushed
the
ncgenerics-xfails-3
branch
from
6151882 to
dcd7b02
Compare
|
swiftlang/llvm-project#8384 |
1 similar comment
|
swiftlang/llvm-project#8384 |
|
swiftlang/llvm-project#8384 |
1 similar comment
|
swiftlang/llvm-project#8384 |
12 tasks
kavon
force-pushed
the
ncgenerics-xfails-3
branch
from
8e60cdb to
3348ff4
Compare
kavon
requested review from
adrian-prantl,
AnthonyLatsis,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
zoecarver,
hyp and
egorzhdan
as code owners
The test was relying on UnsafeMutablePointer (UMP) not having a Copyable requirement. Those Copyable requirements are more prominent when using the new infrastructure for noncopyable types. Since UMP is planned to have `~Copyable` on its generic parameter quite soon, this shouldn't remain broken for too long.
It's not currently clear whether this is a regression or just a test that needs updating. Investigation is needed.
It's not currently clear whether this is a regression or just a test that needs updating. For now it seems harmless to just update the test rather than disable it.
This test is failing to verify the generic signature for this bogus program, because the generic signature isn't minimal. We should gracefully handle this situation and still have a minimal signature, despite rejecting this program.
The presence of Copyable/Escapable conformances doesn't affect ABI. Only their absence in terms of suppressed requirements like `~Copyable` need to be output for diffing by the APIDigester.
This appears to be a code path that wasn't previously stressed when deserializing a bogus module, but now it is with NoncopyableGenerics, as Copyable is often emitted as a builtin conformance.
After removing the implicit conditional conformance synthesis for inverses, this test wasn't updated.
kavon
force-pushed
the
ncgenerics-xfails-3
branch
from
c1f1edc to
ca25edb
Compare
|
swiftlang/llvm-project#8384 |
|
swiftlang/llvm-project#8384 |
|
swiftlang/llvm-project#8384 |
kavon
force-pushed
the
ncgenerics-xfails-3
branch
from
a554dfc to
ca25edb
Compare
|
swiftlang/llvm-project#8384 |
|
swiftlang/llvm-project#8384 |
|
swiftlang/llvm-project#8384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on swiftlang/llvm-project#8384
This PR switches the compiler over to use the infrastructure underpinning NoncopyableGenerics, without actually enabling that experimental feature. This means the compiler can take advantage of the newer, better diagnostics that are now the same whether you enable the feature or not. Overall this is meant to be an NFC.
As a result of using the new infrastructure, it's possible to remove a bunch of old scaffolding code that was used either for the old or new infrastructure. For example, we no longer need a special flag in the control block of the swiftmodule to indicate whether it was compiled with NoncopyableGenerics infrastructure, since it's just always used as of this new module version.