SIL: Ignore AEIC on package declaration inside declarations without effective public access #73708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffective public access Quoting Slava: "The AST-level access is allowed to be 'more public'. I honestly don't know why, but it's always worked this way and the 'lowered' access levels must always intersect the access levels of the parents but with @UIC, @aeic and @inlinable, that means just ignoring those attributes if some enclosing context is not @UIC" rdar://128270848
|
@swift-ci test |
|
Shouldn't we diagnose the no-opness of |
|
No, apparently (and surprisingly) this is “expected” behavior. See Slava’s quote. |
|
The change here is to mirror the existing behavior of internal in the case of package accces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting Slava:
"The AST-level access is allowed to be 'more public'. I honestly don't know why, but it's always worked this way and the 'lowered' access levels must always intersect the access levels of the parents but with @UIC, @aeic and @inlinable, that means just ignoring those attributes if some enclosing context is not @UIC"
rdar://128270848