Skip to content

stdlib: Add runtime support for zippered availability checks #75646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Aug 2, 2024

Now that __isPlatformOrVariantPlatformVersionAtLeast() is available in upstream LLVM (llvm/llvm-project#100605), the implementation of the zippered variant of the OS version check utility can use the targetOSVersionOrVariantOSVersionAtLeast builtin safely.

Resolves rdar://103960437.

Now that `__isPlatformOrVariantPlatformVersionAtLeast()` is available in
upstream LLVM, the implementation of the zippered variant of the OS version
check utility can use the `targetOSVersionOrVariantOSVersionAtLeast` builtin
safely.

Resolves rdar://103960437.
@tshortli tshortli requested review from jckarter and a team as code owners August 2, 2024 17:27
@tshortli
Copy link
Contributor Author

tshortli commented Aug 2, 2024

@swift-ci please test

@tshortli tshortli requested a review from etcwilde August 2, 2024 17:27
Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like __isPlatformOrVariantPlatformVersionAtLeast() is available on all of the llvm branches. Thanks for doing this work.

@tshortli tshortli enabled auto-merge August 2, 2024 19:50
@tshortli tshortli merged commit 65bf2d0 into swiftlang:main Aug 2, 2024
4 of 5 checks passed
@tshortli tshortli deleted the zippered-os-version-at-least-or-variant-at-least branch August 2, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants