Add -Xfrontend -mergeable-traps as a way to emit mergeable traps #76045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
MaxDesiatov,
phausler,
rauhul,
zoecarver and
eeckstein
kubamracek
requested review from
rjmccall,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
rauhul
approved these changes
Aug 22, 2024
kubamracek
force-pushed
the
mergeable-traps
branch
from
d90423c to
ff04af4
Compare
eeckstein
reviewed
Sep 17, 2024
| @@ -503,7 +503,7 @@ llvm::CallInst *IRBuilder::CreateNonMergeableTrap(IRGenModule &IGM, | |||
| } | |||
| } | |||
|
|
|||
| if (IGM.IRGen.Opts.shouldOptimize()) { | |||
There was a problem hiding this comment.
Shouldn't we keep IGM.IRGen.Opts.shouldOptimize(), too?
kubamracek
force-pushed
the
mergeable-traps
branch
from
ff04af4 to
6e0d765
Compare
Done! |
|
@swift-ci please test |
kubamracek
force-pushed
the
mergeable-traps
branch
from
e685980 to
23e4d64
Compare
|
@swift-ci please test |
kubamracek
force-pushed
the
mergeable-traps
branch
from
23e4d64 to
934e11a
Compare
…perimental features
kubamracek
force-pushed
the
mergeable-traps
branch
from
934e11a to
859c565
Compare
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only adding as a hidden frontend flag, not intending this to actually be used in normal production code. But this is potentially useful for Embedded Swift and especially codesize constrained environments: (1) A/B testing to see how much codesize are we paying for non-mergeable traps, (2) if it's appropriate in special cases to regress debuggability to save on codesize.