Refactoring of the TaskLocal::Item #77241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace NextLinkType with Item::Kind with more clear definition. Use llvm::PointerIntPair<>. Use hierarchy of classes instead of optional fields inside Item. Combined Storage::copyToOnlyOnlyFromCurrentGroup() into Storage::initializeLinkParent(). Also create parent task marker when copying items created inside withTaskGroup(). Removed Storage::peekHeadLinkType().
|
@swift-ci please smoke test |
ktoso
reviewed
Oct 28, 2024
| /// | ||
| /// Items of this kind must be copied by a group child task for access | ||
| /// safety reasons, as otherwise the pop would happen before the child | ||
| /// task |
There was a problem hiding this comment.
minor: may wanna join this and the next line
ktoso
reviewed
Oct 28, 2024
| /// does not "contribute" any task local values. This is to speed up | ||
| /// lookups by skipping empty parent tasks during get(), and explained | ||
| /// in depth in `initializeLinkParent()`. | ||
| ParentTaskMarker = 2 |
There was a problem hiding this comment.
Ok, I like that way of expressing it
ktoso
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
NextLinkTypewithItem::Kindwith more clear definition. Usellvm::PointerIntPair<>. Use hierarchy of classes instead of optional fields inside Item.Combined
Storage::copyToOnlyOnlyFromCurrentGroup()intoStorage::initializeLinkParent(). Also create parent task marker when copying items created insidewithTaskGroup(). RemovedStorage::peekHeadLinkType().