-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[cxx-interop] Make Cxx and CxxStdlib libraries resilient #77559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This enables library evolution for the two libraries that form the Swift overlay for the C++ standard library. rdar://129169673
@swift-ci please test |
@swift-ci please benchmark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@swift-ci please test Linux |
Performance (x86_64): -O
Code size: -O
Performance (x86_64): -Osize
Code size: -Osize
Performance (x86_64): -Onone
Code size: -swiftlibs |
The benchmarks seem to be noisy. The only performance regressions are in CxxSpanTests.map and CxxSpanTests.filter. We can provide overloads |
These two libraries are now built with library evolution enabled. See swiftlang/swift#77559
@egorzhdan it seems like this PR/commit may be related to the linker issue I'm seeing: #77756 WDYT? |
This enables library evolution for the two libraries that form the Swift overlay for the C++ standard library.
rdar://129169673