Skip to content

[CSSimplify] Handle invalid type specializations #77652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Nov 15, 2024

If the base type of the specialization is invalid, the AST node is going to be replaced with ErrorExpr.

We need to handle that gracefully when attempting
to apply specialization in such situations.

Resolves: #77644

If the base type of the specialization is invalid,
the AST node is going to be replaced with `ErrorExpr`.

We need to handle that gracefully when attempting
to apply specialization in such situations.

Resolves: swiftlang#77644
@xedin xedin requested a review from hamishknight November 15, 2024 19:14
@xedin xedin requested a review from hborla as a code owner November 15, 2024 19:14
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xedin
Copy link
Contributor Author

xedin commented Nov 15, 2024

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Nov 15, 2024

@swift-ci please smoke test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Nov 16, 2024

@swift-ci please test

@xedin xedin merged commit 26e888e into swiftlang:main Nov 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid type leads to "Failed to produce diagnostic for expression"
2 participants