Skip to content

[BuildSystem] Stop building for i386-watch-simulator #77692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

cyndyishida
Copy link
Contributor

In Xcode16 it is not supported.

resolves: rdar://138924057

@cyndyishida
Copy link
Contributor Author

@swift-ci please test

@cyndyishida
Copy link
Contributor Author

@swift-ci please test

@cyndyishida
Copy link
Contributor Author

@swift-ci please test

@cyndyishida
Copy link
Contributor Author

@swift-ci please test

@cyndyishida
Copy link
Contributor Author

@egorzhdan Do you know if there are additional changes needed for disabling i386-watch-sim for the Cxx & Cxxstdlib modules?

@cyndyishida
Copy link
Contributor Author

@swift-ci please test

@cyndyishida
Copy link
Contributor Author

Going to merge this, the macOS log shows builds of x86_64-watch-sim and nothing for i386

@cyndyishida cyndyishida merged commit 1ab968d into swiftlang:main Nov 20, 2024
5 checks passed
@egorzhdan
Copy link
Contributor

@cyndyishida there shouldn't be any extra changes required for Cxx and CxxStdlib, removing i386 from SUPPORTED_WATCHOS_SIMULATOR_ARCHS should be enough

al45tair added a commit to al45tair/swift that referenced this pull request Nov 27, 2024
This was broken by swiftlang#77692.

rdar://140313372
cyndyishida added a commit to cyndyishida/swift that referenced this pull request Dec 3, 2024
…ng#77692)"

This reverts commit 1ab968d.

This change can't be made without other issues fixed downstream first.
cyndyishida added a commit that referenced this pull request Dec 4, 2024
* Revert "[Build] Fix swift_build_support tests."

This reverts commit fc2d1b3.

* Revert "[BuildSystem] Stop building for i386-watch-simulator (#77692)"

This reverts commit 1ab968d.

This change can't be made without other issues fixed downstream first.
@cyndyishida cyndyishida deleted the eng/PR-138924057 branch January 29, 2025 18:29
cyndyishida added a commit to cyndyishida/swift that referenced this pull request Jan 29, 2025
…ang#77692)'

    * [BuildSystem] Stop building for i386-watch-simulator

    In Xcode16 it is not supported.

This initially broke client projects who were still building the legacy
architecture but now thats resolved.
cyndyishida pushed a commit to cyndyishida/swift that referenced this pull request Jan 29, 2025
This was broken by swiftlang#77692.

rdar://140313372
cyndyishida added a commit that referenced this pull request Jan 31, 2025
…' (#79018)

* Reapply '[BuildSystem] Stop building for i386-watch-simulator (#77692)'

    * [BuildSystem] Stop building for i386-watch-simulator

    In Xcode16 it is not supported.

This initially broke client projects who were still building the legacy
architecture but now that's resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants