[windows][toolchain] Enable sccache for Clang and add version checks #77874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need sccache 0.7.4 or newer for clang support
compnerd
approved these changes
Nov 30, 2024
weliveindetail
changed the title
weliveindetail
commented
Dec 4, 2024
| @@ -2745,6 +2748,13 @@ try { | |||
| Fetch-Dependencies | |||
|
|
|||
| if (-not $SkipBuild) { | |||
| if (-Not (Test-CMakeAtLeast -Major 3 -Minor 28)) { | |||
| throw "Minimum required CMake version is 3.28" | |||
There was a problem hiding this comment.
CMake 3.28+ is now required globally: https://github.com/swiftlang/swift/blob/main/tools/swift-inspect/CMakeLists.txt#L1
|
Closing this as the above PR contains these patches now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need sccache 0.7.4 (Nov. 2023) or newer for clang support: mozilla/sccache#1983