[windows] build.ps1 polishing #77875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Nov 30, 2024
| @@ -828,6 +828,21 @@ function Get-PinnedToolchainVersion() { | |||
| throw "PinnedVersion must be set" | |||
| } | |||
|
|
|||
| function Get-ClangDriverName([Platform] $Platform, [string] $Lang) { | |||
There was a problem hiding this comment.
Should we enumerate the languages? Perhaps that is overly complicating the state.
…nd give both an optional Name param
weliveindetail
force-pushed
the
buildps1-polishing
branch
from
6a38596 to
fa889f3
Compare
This was referenced Dec 4, 2024
|
Closing this as the above PR contains these patches now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor modifications to prepare for reduction of complexity in
Build-CMakeProjectfunction in the the step