[region-isolation] Perform checking of non-Sendable results using rbi rather than Sema. #77900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested review from
ktoso,
hborla,
slavapestov,
xedin and
eeckstein
as code owners
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
… rather than Sema. In terms of the test suite the only difference is that we allow for non-Sendable types to be returned from nonisolated functions. This is safe due to the rules of rbi. We do still error when we return non-Sendable functions across isolation boundaries though. The reason that I am doing this now is that I am implementing a prototype that allows for nonisolated functions to inherit isolation from their caller. This would have required me to implement support both in Sema for results and arguments in SIL. Rather than implement results in Sema, I just finished the work of transitioning the result checking out of Sema and into SIL. The actual prototype will land in a subsequent change. rdar://127477211
Importantly since this test had a typechecker error within it, we do not get return value diagnostics anymore since that occurs now at SIL time.
gottesmm
force-pushed
the
rdar127477211
branch
from
bf2544e to
3b8e384
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
I tried to port this behavior to another test that validated the behavior using RBI. When I tried to do so I ran into the issue that the behavior in this test only reproduces in targeted mode not in complete mode which is required for rbi to run.
gottesmm
force-pushed
the
rdar127477211
branch
from
f015f68 to
784d193
Compare
|
@swift-ci smoke test |
|
:sigh: lost my MSVC fix when doing force pushes... repushed it. |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[region-isolation] Perform checking of non-Sendable results using rbi rather than Sema.
In terms of the test suite the only difference is that we allow for non-Sendable
types to be returned from nonisolated functions. This is safe due to the rules
of rbi. We do still error when we return non-Sendable functions across isolation
boundaries though.
The reason that I am doing this now is that I am implementing a prototype that
allows for nonisolated functions to inherit isolation from their caller. This
would have required me to implement support both in Sema for results and
arguments in SIL. Rather than implement results in Sema, I just finished the
work of transitioning the result checking out of Sema and into SIL. The actual
prototype will land in a subsequent change.
rdar://127477211
I did the test updates in a separate commit to make it a little easier to review.