[windows] Consolidate dependency infos in build.ps1 (NFC) #77945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once LLDB test infrastructure landed, we can add weliveindetail@buildps1-consolidate-deps-infos-with-lldb-testing |
|
Closing this as the above PR contains these patches now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent move away from host Python, additional modules and the upcoming LLDB test dependencies are adding 3rd-party dependencies to the build script and their URLs/hashes/version kept spreading throughout the code. This patch is an attempt to consolidate the required data in a
$Componentsmap that is indexed with an abstract name. Each item has the fieldsURLandHashbut isn't limited to that. ThePinnedSwiftitems for example have an extraVersionfield.Major refactors in this patch are:
DownloadAndVerifywas changed. It takes an abstract component name now instead of URL/Hash.Ensure-PythonModulewas added. It takes a Python module name and checks/installs that.Ensure-PythonModuleswas dropped$PinnedBuild/SHA256/Versionremain bare parameter values and don't get overwritten anymore.$PinnedSwiftcontains the component name that selects which pinned toolchain is used.