Skip to content

utils: unlock building swift-inspect #78067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

hjyamauchi
Copy link
Contributor

@hjyamauchi hjyamauchi commented Dec 9, 2024

When building for ARM64, we can now build swift-inspect as we use CMake for the cross-compilation.

This is a second attempt for #77810

This should fix https://ci-external.swift.org/job/swift-main-windows-toolchain-arm64/792/

         C:\Users\swift-ci\jenkins\workspace\swift-main-windows-toolchain-arm64\swift-installer-scripts\platforms\Windows\dbg\dbg.wxs(110): error WIX0103: Cannot find the File file 'T:\\Program Files\\Swift\\Toolchains\\6.0.0+Asserts\\usr\bin\swift-inspect.exe'. The following paths were checked: T:\\Program Files\\Swift\\Toolchains\\6.0.0+Asserts\\usr\bin\swift-inspect.exe [C:\Users\swift-ci\jenkins\workspace\swift-main-windows-toolchain-arm64\swift-installer-scripts\platforms\Windows\dbg\dbg.wixproj]

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi hjyamauchi marked this pull request as ready for review December 9, 2024 19:51
@hjyamauchi hjyamauchi requested a review from compnerd December 9, 2024 19:51
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi
Copy link
Contributor Author

@compnerd PTAL

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

When building for ARM64, we can now build swift-inspect as we use CMake
for the cross-compilation.

This is a second attempt for swiftlang#77810
@compnerd
Copy link
Member

compnerd commented Dec 9, 2024

@swift-ci please test

@compnerd compnerd enabled auto-merge December 10, 2024 01:50
@compnerd compnerd merged commit 37033a7 into swiftlang:main Dec 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants