UTF8Span #78531

milseman · 2025-01-09T20:42:12Z

CI Toolchain status

Current toolchain: https://ci.swift.org/job/swift-PR-toolchain-macos/1865/artifact/branch-main/swift-PR-78531-1865-osx.tar.gz

Usage

Before unpacking the tar ball, clear attributes via xattr -c swift-PR-78531-*.tar

Use DYLD_LIBRARY_PATH and the bundled swift executable via

DYLD_LIBRARY_PATH=~/Downloads/Library/Developer/Toolchains/swift-PR-78531-xxxx.xctoolchain/usr/lib/swift/macosx  ~/Downloads/Library/Developer/Toolchains/swift-PR-78531-xxxx.xctoolchain/usr/bin/swift run

Known issues

The String.utf8Span property is unavailable, pending [SE-0456] Span properties over utf8 views #80116.
Canonical comparisons can be slow, pending some more internal refactoring
checkForNFC(quickCheck: true) is unavailable, pending some more internal refactoring
canonicallyPrecedes is still called isCanonicallyLessThan

milseman · 2025-01-10T19:40:43Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-02-19T13:35:55Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-03-02T22:32:04Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-03-03T14:53:37Z

Previous toolchain: https://ci.swift.org/job/swift-PR-toolchain-macos/1817/

https://download.swift.org/tmp/pull-request/78531/1817/xcode/swift-PR-78531-1817-osx.tar.gz

milseman · 2025-03-03T14:53:43Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-03-03T19:50:57Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-03-06T16:25:22Z

Newer toolchain: https://ci.swift.org/job/swift-PR-toolchain-macos/1820/artifact/branch-main/swift-PR-78531-1820-osx.tar.gz

milseman · 2025-03-08T22:19:14Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-03-09T14:15:04Z

New toolchain: https://ci.swift.org/job/swift-PR-toolchain-macos/1841/artifact/branch-main/swift-PR-78531-1841-osx.tar.gz

milseman · 2025-03-17T15:10:01Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-03-17T21:48:13Z

Toolchain: https://ci.swift.org/job/swift-PR-toolchain-macos/1865/artifact/branch-main/swift-PR-78531-1865-osx.tar.gz

milseman · 2025-03-17T23:27:31Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-03-27T19:09:01Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-03-28T15:14:52Z

@swift-ci please test

milseman · 2025-03-31T16:30:54Z

@swift-ci please test

milseman · 2025-04-04T19:47:40Z

@swift-ci Please Build Toolchain macOS Platform

milseman · 2025-04-04T19:47:48Z

@swift-ci please test

milseman · 2025-04-06T03:06:49Z

@swift-ci please test

milseman · 2025-04-06T06:28:47Z

@swift-ci please test

milseman · 2025-04-06T15:26:49Z

@swift-ci please test

milseman · 2025-04-06T17:30:55Z

@swift-ci please test

Internal refactoring. Validation now produces a (discardable) reason validation failed (only checked on slow-path). _hasGraphemeBreakBetween has been refactored to represent its quick-check nature.

milseman · 2025-04-07T13:17:18Z

@swift-ci please test

milseman · 2025-04-07T13:31:10Z

@swift-ci please test

wip: closer to proposal wip wip: more implementation wip: add back in comparison functions wip: more iterator testing Detangle grapheme breaking guts from string guts Further untangling wip wip: use internal grapheme breaking Call internal impl directly wip refactoring wip: might be broken wip: update to lifetime changes wip: wire up nfc quick check wip: validation error rename SQUASH ME: unsafe annotations, final API wip: fixup availability wip: re-arrange availability wip: x86 abi additions wip: fix availability wip: Windows build support wip: refine assertions

milseman · 2025-04-09T19:13:31Z

(As a note for the future, since bot history got removed, full CI testing passed.)

milseman · 2025-04-09T20:00:50Z

@swift-ci please test

milseman · 2025-04-10T00:57:08Z

@swift-ci please test

milseman · 2025-04-10T12:27:10Z

Passing CI build: https://ci.swift.org/job/swift-PR-macos/21480/

compnerd

The build changes seem fine to me.

compnerd · 2025-04-10T17:14:49Z

Runtimes/Core/core/CMakeLists.txt

+  UTF8SpanFundamentals.swift
+  UTF8SpanInternalHelpers.swift
+  UTF8SpanIterators.swift
+  UTF8EncodingError.swift


Is this sorted properly? Should they be ordered around UTF8.swift?

I went through and put them in alphabetical order, thanks.

stdlib/public/core/StringGraphemeBreaking.swift

glessard · 2025-04-10T22:19:06Z

stdlib/public/core/StringUTF8Validation.swift

-  @inline(__always) func guaranteeIn(_ f: (UInt8) -> Bool) throws(UTF8ValidationError) {
-    guard let cu = unsafe iter.next() else { throw UTF8ValidationError() }
-    guard f(cu) else { throw UTF8ValidationError() }
+  @inline(__always) func guarantee(


Suggested change

@inline(__always) func guarantee(

@inline(__always)

internal func guarantee(

This is a nested function, so we can't attach internal to it.

glessard · 2025-04-10T22:19:38Z

stdlib/public/core/StringUTF8Validation.swift

  }
-  @inline(__always) func guaranteeContinuation() throws(UTF8ValidationError) {
-    try guaranteeIn(UTF8.isContinuation)
+  @inline(__always) func guaranteeContinuation(


Suggested change

@inline(__always) func guaranteeContinuation(

@inline(__always)

internal func guaranteeContinuation(

stdlib/public/core/UTF8Span.swift

Co-authored-by: Guillaume Lessard <[email protected]>

milseman · 2025-04-11T00:55:21Z

@swift-ci please test

milseman · 2025-04-11T03:04:33Z

@swift-ci please test linux platform

milseman · 2025-04-11T12:13:01Z

@swift-ci please test windows platform

milseman · 2025-04-11T12:13:09Z

@swift-ci please test linux platform

milseman · 2025-04-11T13:18:54Z

@swift-ci please test

Add support for UTF8Span Also, refactor validation and grapheme breaking

milseman force-pushed the utf8span branch from 2b210ac to f28eaa2 Compare February 10, 2025 20:12

milseman force-pushed the utf8span branch from f28eaa2 to 4b9cd93 Compare March 2, 2025 22:18

milseman force-pushed the utf8span branch from b8d90e0 to 24d6b8a Compare March 27, 2025 19:03

milseman force-pushed the utf8span branch from 24d6b8a to e9d12a4 Compare April 4, 2025 19:47

[String] Refactor validation and grapheme breaking

4fa7822

Internal refactoring. Validation now produces a (discardable) reason validation failed (only checked on slow-path). _hasGraphemeBreakBetween has been refactored to represent its quick-check nature.

milseman force-pushed the utf8span branch from 7341ec0 to a5cf19c Compare April 7, 2025 13:16

UTF8Span: add in new argument names

2aa15be

wip: new ABI symbols

4526c89

milseman marked this pull request as ready for review April 10, 2025 17:04

milseman requested review from a team, etcwilde, compnerd, edymtt and justice-adams-apple as code owners April 10, 2025 17:04

milseman requested a review from glessard April 10, 2025 17:04

compnerd approved these changes Apr 10, 2025

View reviewed changes

glessard approved these changes Apr 10, 2025

View reviewed changes

SQUASH ME: string copying init

dd0fcc4

milseman changed the title ~~DRAFT: UTF8Span~~ UTF8Span Apr 11, 2025

milseman and others added 3 commits April 10, 2025 18:24

Update stdlib/public/core/StringGraphemeBreaking.swift

1ae2475

Co-authored-by: Guillaume Lessard <[email protected]>

Update stdlib/public/core/UTF8Span.swift

bfdf899

Co-authored-by: Guillaume Lessard <[email protected]>

wip: build file reorder and delete dead code

14fb318

wip: fixup overload test

4202686

milseman merged commit e6e4bd6 into swiftlang:main Apr 11, 2025
5 checks passed

milseman deleted the utf8span branch April 11, 2025 22:11

milseman added a commit to milseman/swift that referenced this pull request Apr 17, 2025

UTF8Span (swiftlang#78531)

8edf948

Add support for UTF8Span Also, refactor validation and grapheme breaking

stephentyrone pushed a commit that referenced this pull request Apr 18, 2025

UTF8Span (#78531) (#80890)

393c24d

Add support for UTF8Span Also, refactor validation and grapheme breaking

	@inline(__always) func guarantee(
	@inline(__always)
	internal func guarantee(

	@inline(__always) func guaranteeContinuation(
	@inline(__always)
	internal func guaranteeContinuation(

UTF8Span #78531

UTF8Span #78531

Uh oh!

Conversation

milseman commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Toolchain status

Usage

Known issues

Uh oh!

milseman commented Jan 10, 2025

Uh oh!

milseman commented Feb 19, 2025

Uh oh!

milseman commented Mar 2, 2025

Uh oh!

milseman commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

milseman commented Mar 3, 2025

Uh oh!

milseman commented Mar 3, 2025

Uh oh!

milseman commented Mar 6, 2025

Uh oh!

milseman commented Mar 8, 2025

Uh oh!

milseman commented Mar 9, 2025

Uh oh!

milseman commented Mar 17, 2025

Uh oh!

milseman commented Mar 17, 2025

Uh oh!

milseman commented Mar 17, 2025

Uh oh!

milseman commented Mar 27, 2025

Uh oh!

milseman commented Mar 28, 2025

Uh oh!

milseman commented Mar 31, 2025

Uh oh!

milseman commented Apr 4, 2025

Uh oh!

milseman commented Apr 4, 2025

Uh oh!

milseman commented Apr 6, 2025

Uh oh!

milseman commented Apr 6, 2025

Uh oh!

milseman commented Apr 6, 2025

Uh oh!

milseman commented Apr 6, 2025

Uh oh!

milseman commented Apr 7, 2025

Uh oh!

milseman commented Apr 7, 2025

Uh oh!

milseman commented Apr 9, 2025

Uh oh!

milseman commented Apr 9, 2025

Uh oh!

milseman commented Apr 10, 2025

Uh oh!

milseman commented Apr 10, 2025

Uh oh!

compnerd left a comment

Choose a reason for hiding this comment

Uh oh!

compnerd Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

milseman Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

glessard Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

milseman Apr 11, 2025

Choose a reason for hiding this comment

milseman commented Jan 9, 2025 •

edited

Loading

milseman commented Mar 3, 2025 •

edited

Loading