Skip to content

🍒Revert "[cxx-interop] Workaround name lookup issues with namespace simd" #79015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: release/6.1
Choose a base branch
from
Draft

🍒Revert "[cxx-interop] Workaround name lookup issues with namespace simd" #79015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions lib/ClangImporter/ImportDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,14 +1155,6 @@ namespace {
decl->getOwningModule() &&
decl->getOwningModule()->getTopLevelModuleName() == "os")
return nullptr;
// Workaround for simd module declaring `namespace simd` on Darwin,
// causing name lookup issues. That namespace declares C++ overlays of
// types that are already refined for Swift, so let's not import the
// namespace (rdar://143007477).
if (decl->getIdentifier() && decl->getName() == "simd" &&
decl->getOwningModule() &&
decl->getOwningModule()->getTopLevelModuleName() == "simd")
return nullptr;
// If this is a top-level namespace, don't put it in the module we're
// importing, put it in the "__ObjC" module that is implicitly imported.
if (!decl->getParent()->isNamespace())
Expand Down
8 changes: 0 additions & 8 deletions test/Interop/Cxx/objc-correctness/simd_quatf.swift
View file
Open in desktop

This file was deleted.