[SymbolGraphGen] Un-revert #78959 and clean up usage of DenseMap #79124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://143865173
|
@swift-ci Please test |
|
@swift-ci Please Test Source Compatibility |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
franklinsch
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #79062 and adds a fix for the failures it caused in the source compatibility tester.
As it turns out,
operator[]onllvm::DenseMapinserts an empty key into the map, which causescontains()to pass, butoperator[]to return a null pointer. This was causing a null-pointer dereference in SymbolGraphGen because i was assuming thatcontains()would still returnfalseon this empty key. The second commit in this PR changes all my uses ofoperator[]to uselookup()andinsert_or_assign()instead, leaving the map completely empty unless there is actually a public type alias of a private decl.