[Parse] Adjust assertions for ParsingFlags::PoundIfAllActive mode #79192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
hamishknight,
CodaFi and
DougGregor
as code owners
|
@swift-ci Please smoke test |
|
Another (probably more correct) option is to use all clauses like foo
#if FLAG
.bar
#else
.baz
#endwould be parsed as |
DougGregor
approved these changes
Feb 6, 2025
bnbarham
approved these changes
Feb 6, 2025
In this mode, multiple #if clauses are active. For now, just use the first clause as the result.
rintaro
force-pushed
the
ifconfig-allactive-postfixexpr
branch
from
a16a0b9 to
635494d
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this mode, multiple #if clauses are active. For now, just use the first clause as the result.