Skip to content

[Concurrency] task names dont need default nil arg #80011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions stdlib/public/Concurrency/Task.swift
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ extension Task where Failure == Never {
@_alwaysEmitIntoClient
@available(*, unavailable, message: "Unavailable in task-to-thread concurrency model")
public init(
name: String? = nil,
name: String?,
priority: TaskPriority? = nil,
@_inheritActorContext @_implicitSelfCapture operation: sending @escaping @isolated(any) () async -> Success
) {
Expand All @@ -662,7 +662,7 @@ extension Task where Failure == Never {
@_alwaysEmitIntoClient
@available(SwiftStdlib 6.2, *)
public init(
name: String? = nil,
name: String?,
// TaskExecutor is unavailable in embedded
priority: TaskPriority? = nil,
@_inheritActorContext @_implicitSelfCapture operation: sending @escaping () async -> Success
Expand Down Expand Up @@ -712,7 +712,7 @@ extension Task where Failure == Never {
@_alwaysEmitIntoClient
@available(SwiftStdlib 6.2, *)
public init(
name: String? = nil,
name: String?,
priority: TaskPriority? = nil,
@_inheritActorContext @_implicitSelfCapture operation: sending @escaping @isolated(any) () async -> Success
) {
Expand Down Expand Up @@ -824,7 +824,7 @@ extension Task where Failure == Error {
@_alwaysEmitIntoClient
@available(*, unavailable, message: "Unavailable in task-to-thread concurrency model")
public init(
name: String? = nil,
name: String?,
priority: TaskPriority? = nil,
@_inheritActorContext @_implicitSelfCapture operation: sending @escaping @isolated(any) () async throws -> Success
) {
Expand All @@ -835,7 +835,7 @@ extension Task where Failure == Error {
@_alwaysEmitIntoClient
@available(SwiftStdlib 6.2, *)
public init(
name: String? = nil,
name: String?,
// TaskExecutor is unavailable in embedded
priority: TaskPriority? = nil,
@_inheritActorContext @_implicitSelfCapture operation: sending @escaping () async throws -> Success
Expand Down Expand Up @@ -881,7 +881,7 @@ self._task = task
@_alwaysEmitIntoClient
@available(SwiftStdlib 6.2, *)
public init(
name: String? = nil,
name: String?,
priority: TaskPriority? = nil,
@_inheritActorContext @_implicitSelfCapture operation: sending @escaping @isolated(any) () async throws -> Success
) {
Expand Down Expand Up @@ -991,7 +991,7 @@ extension Task where Failure == Never {
@_alwaysEmitIntoClient
@available(*, unavailable, message: "Unavailable in task-to-thread concurrency model")
public static func detached(
name: String? = nil,
name: String?,
priority: TaskPriority? = nil,
operation: sending @escaping @isolated(any) () async -> Success
) -> Task<Success, Failure> {
Expand Down Expand Up @@ -1022,7 +1022,7 @@ extension Task where Failure == Never {
@discardableResult
@_alwaysEmitIntoClient
public static func detached(
name: String? = nil,
name: String?,
priority: TaskPriority? = nil,
operation: sending @escaping @isolated(any) () async -> Success
) -> Task<Success, Failure> {
Expand Down Expand Up @@ -1132,7 +1132,7 @@ extension Task where Failure == Error {
@_alwaysEmitIntoClient
@available(*, unavailable, message: "Unavailable in task-to-thread concurrency model")
public static func detached(
name: String? = nil,
name: String?,
priority: TaskPriority? = nil,
operation: sending @escaping @isolated(any) () async throws -> Success
) -> Task<Success, Failure> {
Expand Down Expand Up @@ -1164,7 +1164,7 @@ extension Task where Failure == Error {
@discardableResult
@_alwaysEmitIntoClient
public static func detached(
name: String? = nil,
name: String?,
priority: TaskPriority? = nil,
operation: sending @escaping @isolated(any) () async throws -> Success
) -> Task<Success, Failure> {
Expand Down
2 changes: 1 addition & 1 deletion stdlib/public/Concurrency/TaskGroup+addTask.swift.gyb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import Swift
% ],
% ['addTask', 'addTaskUnlessCancelled'],
% [
% 'name: String? = nil',
% 'name: String?',
% 'executorPreference taskExecutor: (any TaskExecutor)? = nil',
% 'priority: TaskPriority? = nil',
% # throws and ChildTaskResult will be adjusted per task group type
Expand Down