[AST] Always walk folded SequenceExpr if available #80242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov,
xedin and
tshortli
as code owners
Expand the special-cased ASTWalker behavior for folded SequenceExprs such that we always walk the folded expression when available. This ensures that we don't attempt to add the same node multiple times when expanding ASTScopes during pre-checking. rdar://147751795
hamishknight
force-pushed
the
mutable-problems-require-mutable-solutions
branch
from
c8c080b to
738c70e
Compare
|
@swift-ci please test |
xedin
approved these changes
Mar 25, 2025
| if (!newExpr) | ||
| return nullptr; | ||
|
|
||
| E->setFoldedExpr(newExpr); |
There was a problem hiding this comment.
For the record, I suggested to Allan to do it this way in his original PR.
There was a problem hiding this comment.
Oh interesting, @tshortli any objections to changing this?
There was a problem hiding this comment.
Going to land for now
There was a problem hiding this comment.
No objections, I just wasn't interested in taking on extra risk by changing the behavior fundamentally for 6.1. If this seems like the right fix in general I'm happy to have it simplified.
|
@swift-ci please test source compatibility Debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the special-cased ASTWalker behavior for folded SequenceExprs such that we always walk the folded expression when available. This ensures that we don't attempt to add the same node multiple times when expanding ASTScopes during pre-checking.
rdar://147751795