Skip to content

utils: Add back missing ToolchainInstallRoot properties. #80294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Mar 26, 2025

These properties were missed in the platform conversion.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not avoid this install path? I believe that we no longer install anything to this directory. It seems like it would be nice if we could always just compute the final location for the toolchain stage.

@jeffdav jeffdav force-pushed the win-build-fix-toolchaininstallroot branch from 35a8810 to 828a347 Compare March 26, 2025 04:43
@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd compnerd enabled auto-merge March 26, 2025 05:07
@compnerd compnerd merged commit 276ced6 into swiftlang:main Mar 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants