[Caching][Macro] Make macro plugin options cacheable #80474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-148465899
branch
from
32d8cab to
f6b1cab
Compare
|
This is part 1. Also need swift-driver and lldb part. |
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-148465899
branch
from
f6b1cab to
c9d216e
Compare
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-148465899
branch
from
c9d216e to
80508df
Compare
|
@swift-ci please smoke test |
benlangmuir
reviewed
Apr 3, 2025
The macro dylibs are not too big right now (biggest fat macro we ship is around 1M), even we are comparing the entire fat binary sometimes. Future improvements are definitely on the table but the good thing is the comparing method is just between frontend and scanner, thus it is easy to make improvements. Few other possibilities without completely redo the logics right now:
|
cachemeifyoucan
force-pushed
the
eng/PR-148465899
branch
from
80508df to
ec1db28
Compare
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-148465899
branch
from
ec1db28 to
101ca60
Compare
|
@swift-ci please smoke test |
|
ping |
benlangmuir
approved these changes
Apr 9, 2025
Currently, the macro plugin options are included as cache key and the absolute path of the plugin executable and library will affect cache hit, even the plugin itself is identical. Using the new option `-resolved-plugin-validation` flag, the macro plugin paths are remapped just like the other paths during dependency scanning. `swift-frontend` will unmap to its original path during the compilation, make sure the content hasn't changed, and load the plugin. It also hands few other corner cases for macro plugins: * Make sure the plugin options in the swift module is prefix mapped. * Make sure the remarks of the macro loading is not cached, as the mesasge includes the absolute path of the plugin, and is not cacheable. rdar://148465899
cachemeifyoucan
force-pushed
the
eng/PR-148465899
branch
from
101ca60 to
3d38d0d
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the macro plugin options are included as cache key and the absolute path of the plugin executable and library will affect cache hit, even the plugin itself is identical.
Using the new option
-resolved-plugin-validationflag, the macro plugin paths are remapped just like the other paths during dependency scanning.swift-frontendwill unmap to its original path during the compilation, make sure the content hasn't changed, and load the plugin. It also hands few other corner cases for macro plugins:rdar://148465899