Skip to content

[Runtime] Handle relative witness tables in _checkWitnessTableIsolation. #80600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Apr 7, 2025

We need to use lookThroughOptionalConditionalWitnessTable when relative witness tables are being used.

rdar://148687148

@mikeash mikeash requested a review from al45tair as a code owner April 7, 2025 17:41
@mikeash mikeash force-pushed the check-witness-table-isolation-ptrauth branch from ec10e5c to bb89ea4 Compare April 7, 2025 17:41
@mikeash mikeash changed the title [Runtime] AUthenticate relative witness tables in _checkWitnessTableIsolation. [Runtime] Authenticate relative witness tables in _checkWitnessTableIsolation. Apr 7, 2025
@mikeash
Copy link
Contributor Author

mikeash commented Apr 7, 2025

@swift-ci please test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeash mikeash force-pushed the check-witness-table-isolation-ptrauth branch from bb89ea4 to e058535 Compare April 8, 2025 18:12
@mikeash
Copy link
Contributor Author

mikeash commented Apr 8, 2025

@swift-ci please test

We need to use lookThroughOptionalConditionalWitnessTable when relative witness tables are being used.

rdar://148687148
@mikeash mikeash force-pushed the check-witness-table-isolation-ptrauth branch from e058535 to f01d46c Compare April 8, 2025 20:15
@mikeash mikeash changed the title [Runtime] Authenticate relative witness tables in _checkWitnessTableIsolation. [Runtime] Handle relative witness tables in _checkWitnessTableIsolation. Apr 8, 2025
@mikeash
Copy link
Contributor Author

mikeash commented Apr 8, 2025

@swift-ci please test

@mikeash mikeash merged commit ee5290a into swiftlang:main Apr 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants