[6.2] IRGen: Fix silly mistake in MetadataPath::followComponent() #80676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression from a00157e. My change made it so that sourceKey.Kind was checked after being overwritten with an abstract conformance, so we would never take the if statement. Incredibly, it almost worked. Fixes rdar://problem/148698142.
slavapestov
force-pushed
the
fix-rdar148698142-6.2
branch
from
979ea42 to
cca31be
Compare
slavapestov
requested review from
ahoppen,
bnbarham,
rintaro,
hamishknight,
shahmishal,
a team,
xymus,
eeckstein,
jckarter,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
ktoso,
mikeash,
al45tair,
AnthonyLatsis,
tshortli,
CodaFi,
DougGregor and
artemcm
as code owners
slavapestov
removed request for
xymus,
mikeash,
etcwilde,
rjmccall,
Xazax-hun,
beccadax,
DougGregor,
edymtt,
bnbarham,
CodaFi,
shahmishal,
al45tair,
egorzhdan,
ahoppen,
artemcm,
hborla,
j-hui,
zoecarver,
ian-twilightcoder,
hnrklssn,
hamishknight,
eeckstein,
tshortli,
AnthonyLatsis,
fahadnayyar,
susmonteiro and
justice-adams-apple
|
@swift-ci Please test |
hborla
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry-pick of #80675.
Description: Fixes an IRGen crash when following a conformance path where some of the intermediate steps are concrete.
Origination: Introduced by Fix a few more callers of ProtocolConformanceRef::forAbstract() to pass in a subject type #80107 right before 6.2 branch.
Radar: rdar://148698142
Risk: Low.
Tested: Added test case for uncovered code path.
Reviewed by: @hborla