Skip to content

[6.2][SymbolGraph] Make symbol-graph output deterministic #80687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

[6.2][SymbolGraph] Make symbol-graph output deterministic #80687

merged 1 commit into from
Apr 14, 2025

Conversation

cachemeifyoucan
Copy link
Contributor

@cachemeifyoucan
[SymbolGraph] Make symbol-graph output deterministic
58087af 
SymbolGraph generation iterating over llvm::DenseSet, which makes the
symbols and relationship fields appear in non-deterministic ordering.
Switch to use llvm::SetVector to preserve the insertion order from
SourceEntityWalker to make order deterministic.

Resolves: swiftlang#59602
(cherry picked from commit dfa4a27)
@cachemeifyoucan cachemeifyoucan requested a review from a team as a code owner April 9, 2025 17:29
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@cachemeifyoucan cachemeifyoucan merged commit be92320 into swiftlang:release/6.2 Apr 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cachemeifyoucan @nkcsgexi