[6.2][BridgingHeaderChaining] Bind bridging header module when load module #80688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cachemeifyoucan
commented
Apr 9, 2025
cachemeifyoucan
commented
- Description: When loading a module with embedded bridging header, bind the bridging header module in the context when bridging header auto chaining is used. This is because all the bridging header contents are chained into a PCH file so binary module with bridging header should reference the PCH file for all declarations.
- Orignal PR: [BridgingHeaderChaining] Bind bridging header module when load module #80512
- Issue: rdar://148538787
- Reviewed by: @artemcm
- Tests: Unit test + full SWB testing
- Risk: Low
When loading a module with embedded bridging header, bind the bridging header module in the context when bridging header auto chaining is used. This is because all the bridging header contents are chained into a PCH file so binary module with bridging header should reference the PCH file for all declarations. rdar://148538787 (cherry picked from commit 02ee2f4)
cachemeifyoucan
changed the title
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
do we only chain bridging headers when CAS is enabled? or every builds with explicit modules on? |
Only CAS is on for now. |
nkcsgexi
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.