[6.2] Fix IRGen for @_addressable params which may be "captured".

[atrick]

Simply omit the 'nocapture' attribute on the parameter.

Fixes rdar://148039510 ([nonescapable] IRGen: lower addressable
params to LLVM: captures(ret: address, provenance))

(cherry picked from commit e40a34d)

main PR: #80708

[atrick]

@swift-ci test

[rizh09]

@CodiumAI-Agent /review

[CodiumAI-Agent]

PR Reviewer Guide 🔍

(Review updated until commit e048dd1)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Attribute Application The newly introduced conditional check for applying the NoCapture attribute when a parameter is not addressable should be verified to ensure it does not affect the intended capture semantics. Confirm that this change aligns with all expected parameter behaviors. if (!addressable && ti.isBitwiseTakable(ResilienceExpansion::Maximal)) b.addAttribute(llvm::Attribute::NoCapture); // The parameter must reference dereferenceable memory of the type. Type Lowering Consistency The new overload of isAddressable with additional parameters and the associated type lowering logic should be carefully reviewed to ensure consistency with existing behavior and to avoid potential misinterpretation of type parameters. return isAddressable(paramIdx, caller->getModule(), caller->getGenericEnvironment(), caller->getModule().Types, caller->getTypeExpansionContext()); } // 'genericEnv' may be null. bool SILFunctionType::isAddressable(unsigned paramIdx, SILModule &module, GenericEnvironment *genericEnv, Lowering::TypeConverter &typeConverter, TypeExpansionContext expansion) {

[atrick]

@swift-ci smoke test

[atrick]

@swift-ci test

[CodiumAI-Agent]

Persistent review updated to latest commit e048dd1