Skip to content

Fix AddressOwnershipLiveRange to include the full range. #80782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Apr 12, 2025

This allows further extension of access scopes.

Fixes rdar://143992296 (Use of RawSpan in switch context causes compiler crash in AddressOwnershipLiveRange)

This allows further extension of access scopes.

Fixes rdar://143992296 (Use of `RawSpan` in switch context causes compiler crash
in AddressOwnershipLiveRange)
@atrick atrick requested a review from eeckstein as a code owner April 12, 2025 06:50
@atrick
Copy link
Contributor Author

atrick commented Apr 12, 2025

@swift-ci test

@atrick atrick merged commit 4b5d519 into swiftlang:main Apr 12, 2025
5 checks passed
@atrick atrick deleted the rdar143992296-addressliverange branch April 12, 2025 22:02
@@ -695,7 +699,6 @@ extension LocalVariableReachableAccess {
continue
case .assign:
accessStack.push(accessInfo.access)
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there any functional change here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, that just looks like a cleanup to avoid confusion with the for-loop break

@meg-gupta
Copy link
Contributor

meg-gupta commented Apr 14, 2025

Not familiar with this code. But the changes look reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants