🍒[cxx-interop] Do not import arithmetic operators with rvalue reference parameters #80798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parameters Currently those operators are imported with a `consuming:` label, which isn't valid in Swift. We could just remove the label from these parameters, but that introduces a source breakage due to name lookup ambiguity. So, to avoid ambiguity, let's not import such operators into Swift. rdar://149020099 (cherry picked from commit eb7adc7)
|
@swift-ci please test |
Xazax-hun
approved these changes
Apr 14, 2025
j-hui
approved these changes
Apr 14, 2025
|
@swift-ci please test Linux |
|
@swift-ci please test Windows |
DougGregor
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Before this change, Swift 6.2 tried importing rvalue parameters of overloaded operators by adding the
consuming:label to the parameter. This isn't valid in Swift and it was causing an assertion failure.Scope: This changes the way C++ overloaded operators are imported.
Risk: Low, this only affects C++ operators with rvalue reference parameters.
Testing: Added a compiler test.
Issue: rdar://149020099
Reviewer: @Xazax-hun @j-hui
Original PR: #80763