[Runtime] Properly deallocate extended storage for conformance cache entries #80865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… free list This memory is part of the conformance cache concurrent hash map, so when we clear the conformance cache, record each of the allocated pointers within the concurrent map's free list. This way, it'll be freed with the rest of the concurrent map when it's safe to do so.
DougGregor
requested review from
mikeash,
al45tair,
rjmccall and
compnerd
as code owners
|
@swift-ci please smoke test |
|
@al45tair FYI! |
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
al45tair
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a conformance cache entry requires extended storage (i.e., for global actor isolation), we were using C++
newto allocate that storage and never freeing it. When the conformance cache gets cleared (e.g, due to loading a shared library containing conformances), these allocations would be leaked.Switch over to
mallocfor these allocations so we don't get tangled with any user-provided C++newimplementations. Keep track of the allocations in a list, and when the conformance cache is cleared, move them over to the freelist for deallocation, eliminating a memory leak.