Skip to content

CMake Embedded Stdlib: mark ExecutorImpl.cpp as optional #80866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

CMake Embedded Stdlib: mark ExecutorImpl.cpp as optional #80866

merged 1 commit into from
Apr 17, 2025
+1 −0

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Apr 16, 2025

This is needed for internal Apple configurations that build the Embedded Stdlib on its own.

Addresses rdar://149410405

@edymtt
CMake Embedded Stdlib: mark ExecutorImpl.cpp as optional
a249e7f 
This is needed for internal Apple configurations that build the Embedded
Stdlib on its own.

Addresses rdar://149410405
@edymtt edymtt requested a review from ktoso as a code owner April 16, 2025 22:48
@edymtt
Copy link
Contributor Author

edymtt commented Apr 16, 2025

@swift-ci please smoke test

@edymtt
Copy link
Contributor Author

edymtt commented Apr 16, 2025

@swift-ci please build toolchain

@al45tair
Copy link
Contributor

Linux build failed with:

<unknown>:0: error: missing required module '_SwiftSyntaxCShims'

Might just have picked a bad moment to run it.

@al45tair
Copy link
Contributor

@swift-ci Please smoke test Linux platform

@al45tair
Copy link
Contributor

Windows build timed-out.

@al45tair
Copy link
Contributor

@swift-ci Please smoke test Windows platform

@edymtt
Copy link
Contributor Author

edymtt commented Apr 17, 2025 •
edited
Loading

Linux testing is failing one test

******************** TEST 'Swift(linux-x86_64) :: Concurrency/Runtime/startSynchronously.swift' FAILED ********************
Exit Code: 1
...
/home/build-user/swift/test/Concurrency/Runtime/startSynchronously.swift:309:11: error: CHECK: expected string not found in input
// CHECK: inside startSynchronously, call rec.sync() done
...

This sounds transient (no other job seem hitting this) and unrelated to this change -- retrying for now.

@edymtt
Copy link
Contributor Author

edymtt commented Apr 17, 2025

@swift-ci please smoke test Linux

@edymtt edymtt enabled auto-merge April 17, 2025 14:00
@edymtt edymtt mentioned this pull request Apr 17, 2025
Merged
@edymtt edymtt merged commit ac07594 into swiftlang:main Apr 17, 2025
6 checks passed
@edymtt edymtt deleted the emiotto/mark-executorimpl_cpp-optional branch April 22, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al45tair al45tair al45tair approved these changes

@etcwilde etcwilde Awaiting requested review from etcwilde

@kubamracek kubamracek Awaiting requested review from kubamracek

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple

@ktoso ktoso Awaiting requested review from ktoso ktoso is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edymtt @al45tair